-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.
Description
Describe the bug
The SyncTarget reconciler sets the syncedResources
state (for a given resource) to Incompatible
when no corresponding APIResourceImport object is found. The Incompatible
state indicates the resource schema is incompatible with the physical cluster schema, which I think in this case is wrong. The Pending
state is better as it indicates the syncer was not able to report compatibility of the resource yet.
This line of code should be changed: https://github.com/kcp-dev/kcp/blob/main/pkg/reconciler/workload/synctargetexports/synctargetcompatible_reconcile.go#L118
Steps To Reproduce
Create a SyncTarget.
Expected Behaviour
Set state to Pending.
Additional Context
No response
Metadata
Metadata
Assignees
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.
Type
Projects
Status
Backlog