Create events in kcp #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ster-runtime/provider commits need them On-behalf-of: @SAP [email protected]
kcp-ci-bot
added
release-note-none
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
kcp-ci-bot
added
size/XL
|
/kind feature |
kcp-ci-bot
added
kind/feature
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
|
LGTM label has been added. Git tree hash: 5eccbe9f7c51e821e3b28c7efccc07b45b33da3e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements basic support for creating sync-related events on objects in kcp. Since the agent has no knowledge of any kind of operators behind it, it at the moment cannot report anything application-specific, and so all the events related to its own operation instead, like
I chose to attempt to keep the synchronization itself to be somewhat subdued. In my mind, users of kcp who make use of APIExports and stuff, should never need to know or care whether their objects are synced/copied/transfered/compressed or whatever behind the scenes to make things work. So the events the agent creates are meant to not constantly remind users that external clusters and synchronizations are involved at all. This is done on a best effort basis though.
In order to create events, the syncagent will now claim
eventsin every APIExport it manages. Existing APIBindings will need to be updated to grant the agent this permission.Additionally, this PR adds
make test-e2eto make quick testing easier.Adding event support required the latest commits of multicluster libraries, which require kube 1.33 already. However latest kcp versions (0.28.1) are on 1.32 still. We chose to break away from kcp because controller-runtime's desire for 1.33 was ultimately stronger.
What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #17
Release Notes