refactor agent to use multicluster-runtime #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
release-note
xrstf
changed the title
kcp-ci-bot
added
the
needs-rebase
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
kcp-ci-bot
removed
the
needs-rebase
|
/unhold |
kcp-ci-bot
removed
the
do-not-merge/hold
|
LGTM label has been added. Git tree hash: d615f19068e45a660571b409149b461952bb456c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the agent to make use of multicluster-runtime and the apiexport provider from multicluster-provider.
Notably, since kube clients do not use the context anymore to switch between clusters, many functions in the syncer now have a dedicated singular
ctxparameter that is used for all kube interactions on both sides of the sync.The e2e tests make use of the ClusterClient in multicluster-runtime to still be scopable down to a specific workspace (but not by setting a context anymore, but by calling
.Cluster(<name>)).Even though the agent is now based on 0.28, it still tests against 0.27 because we found kcp-dev/kcp#3527 during testing (and there are more slight adjustments that we'd need to make to support 0.28).
What Type of PR Is This?
/kind feature
Release Notes
/hold
This must not be merged before kcp 0.28 is released.