Add E2E tests for Override Policy/Namespace level in the dashboard

[SunsetB612]

No description provided.

[karmada-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign samzong for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @SunsetB612, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the dashboard's E2E test suite by removing several specific namespace-related tests and repurposing a general list test to focus on CronJobs. It also introduces the Kubernetes client for Node.js, indicating a potential shift towards more robust or direct interaction with Kubernetes resources in the dashboard's testing infrastructure or application logic. The changes appear to be a refactoring and update of the E2E testing framework rather than adding new tests for "Override Policy/Namespace level" as suggested by the title.

Highlights

• Removed Namespace E2E Tests: Several existing Playwright E2E tests for namespace creation, deletion, and network error handling have been removed from the dashboard's test suite.
• Refactored List E2E Test: The namespace-list.spec.ts file has been renamed to cronjob-list.spec.ts and its content updated to test the display of CronJob lists instead of namespace lists.
• Dependency Addition: The @kubernetes/client-node package has been added as a dependency, along with its transitive dependencies, suggesting preparation for more direct Kubernetes API interactions within the dashboard's testing or functionality.
• Dependency Updates: Various other dependencies in pnpm-lock.yaml have been updated, including @types/node.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request has a misleading title. It states 'Add E2E tests for Override Policy/Namespace level in the dashboard', but the changes primarily involve removing several E2E tests for namespaces and adding a new test for CronJob listing. Removing tests for existing functionality is a significant regression in test coverage. Please clarify the intent of this PR and update the title to accurately reflect the changes. If the namespace tests are no longer needed, an explanation would be beneficial.

I have also left a comment on the new CronJob test file to improve its maintainability.

[gemini-code-assist]

The variable names and comments in this test are inconsistent with the functionality being tested. The test is for 'Cronjob', but the variable is named statefulsetTab and comments refer to 'StatefulSet'. This can be confusing for future maintenance. Please update them to refer to 'Cronjob'.

Suggested change

	// 点击可见的 Statefulset tab
	const statefulsetTab = page.locator('role=option[name="Cronjob"]');
	await statefulsetTab.waitFor({ state: 'visible', timeout: 30000 });
	await statefulsetTab.click();
	// 验证选中状态
	await expect(statefulsetTab).toHaveAttribute('aria-selected', 'true');
	// 验证 StatefulSet 列表表格可见
	const table = page.locator('table');
	await expect(table).toBeVisible({ timeout: 30000 });
	// 点击可见的 Cronjob tab
	const cronjobTab = page.locator('role=option[name="Cronjob"]');
	await cronjobTab.waitFor({ state: 'visible', timeout: 30000 });
	await cronjobTab.click();
	// 验证选中状态
	await expect(cronjobTab).toHaveAttribute('aria-selected', 'true');
	// 验证 Cronjob 列表表格可见
	const table = page.locator('table');
	await expect(table).toBeVisible({ timeout: 30000 });

[SunsetB612]

/hold

[SunsetB612]

/unhold