-
Notifications
You must be signed in to change notification settings - Fork 656
operator pulsar-resources-operator (0.14.0) #6817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
operator pulsar-resources-operator (0.14.0) #6817
Conversation
Signed-off-by: streamnativebot <[email protected]>
|
Dear @streamnativebot, Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.
|
credentials.json: | | ||
{ | ||
"type": "sn_service_account", | ||
"client_secret": "client_secret", | ||
"client_email": "client-email", | ||
"issuer_url": "issuer_url", | ||
"client_id": "client-id" | ||
} | ||
kind: Secret | ||
metadata: | ||
name: test-credentials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericsyh @tuteng @yuweisung There is currently 7 unattended PRs for pulsar-resources-operator, all failing the deployment test. I noticed small difference comparing to the successful releases: you are newly adding couple of secrets like this one, referenced only in the alm-examples
. Are the secret files necessary? If yes, then I think it should be base64 encoded.
Can you please check and also review the older PRs, if it is OK to close them or are needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reminder. I'll invite the member to take a look at it
Signed-off-by: streamnativebot [email protected]
Thanks submitting your Operator. Please check below list before you create your Pull Request.
New Submissions
Updates to existing Operators
ci.yaml
file according to the update instructions?replaces
property if you chosereplaces-mode
via theupdateGraph
property inci.yaml
?package.yaml
orannotations.yaml
?Your submission should not
Operator Description must contain (in order)
Operator Metadata should contain
Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here