chore: remove trailing space from directory paths in postman and address typos in the repo #9114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s cloning Fixed invalid path 'postman/collection-dir/.../Scenario10-Create 3DS payment without external 3ds authentication /.meta.json' by removing trailing space from directory name. This resolves the Windows filesystem compatibility issue where trailing spaces in file/folder names are not allowed, causing git clone to fail on Windows. Fixes juspay#9111 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
pixincreate
previously approved these changes
Aug 31, 2025
pixincreate
added
A-CI-CD
- Fix 'aqcuired' -> 'acquired' in api_locking.rs - Fix 'addtional' -> 'additional' in payment_methods.rs - Fix 'fo' -> 'for' in nuvei transformers.rs 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
pixincreate
reviewed
Sep 1, 2025
| @@ -1404,7 +1404,7 @@ where | |||
| card_holder_name: data.card_holder_name, | |||
| expiration_month: Some(data.card_exp_month), | |||
| expiration_year: Some(data.card_exp_year), | |||
| ..Default::default() // CVV should be disabled by nuvei fo | |||
| ..Default::default() // CVV should be disabled by nuvei for | |||
There was a problem hiding this comment.
Suggested change
| ..Default::default() // CVV should be disabled by nuvei for | |
| ..Default::default() // CVV should be disabled for nuvei |
correct me if wrong, @Nithin1506200
There was a problem hiding this comment.
also, you do not need to merge from main when this branch goes out of date with the base branch (main).
pixincreate
previously approved these changes
Sep 2, 2025
likhinbopanna
previously approved these changes
Sep 2, 2025
pixincreate
changed the title
|
@shivamgupta88, can you please update the PR description by moving it to the right place? also update the description to include the typos being fixed in the repo. |
shivamgupta88
dismissed stale reviews from likhinbopanna and pixincreate
via
c35eeb8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s cloning
Fixed invalid path 'postman/collection-dir/.../Scenario10-Create 3DS payment without external 3ds authentication /.meta.json' by removing trailing space from directory name. This resolves the Windows filesystem compatibility issue where trailing spaces in file/folder names are not allowed, causing git clone to fail on Windows.
Fixes #9111
Type of Change
Description
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy