-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix(connector): [Access Worldpay] correct enum deserialization for payment responses for #8689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Gnanasundari24
merged 2 commits into
main
from
8687-bug-refused-payment-responses-missing-error-codes-and-messages-for-access-worldpay
Jul 21, 2025
Merged
fix(connector): [Access Worldpay] correct enum deserialization for payment responses for #8689
Gnanasundari24
merged 2 commits into
main
from
8687-bug-refused-payment-responses-missing-error-codes-and-messages-for-access-worldpay
Jul 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files
|
2 tasks
deepanshu-iiitu
previously approved these changes
Jul 18, 2025
deepanshu-iiitu
approved these changes
Jul 18, 2025
dgeee13
approved these changes
Jul 18, 2025
pixincreate
added a commit
that referenced
this pull request
Jul 22, 2025
…ordea-sepa * 'main' of github.com:juspay/hyperswitch: refactor(connector): [Adyen] map ssn and session validity for Pix (#8702) feat(core): Implement UCS kill switch for emergency fallback (#8651) fix(openapi): Added Error Response Schema for Status Code 400 (#8684) feat(connector): Add template code for breadpay (#8655) chore(version): 2025.07.21.1 refactor(payments): fetch payment method information in attempts list api v2 and add custom billing connector template (#8681) fix(router): Make v2 endpoints follow standard naming conventions (#8630) fix(connector): [Cybersource] Add type_selection_indicator as 1 for all cards (#8663) feat(routing): Add API key auth for decision engine endpoints (#8640) feat(authentication): Added eligibility flow for modular authentication (#8431) feat(connector): [BLACKHAWKNETWORK] Add Template Code (#8632) fix: remove straight through routing from routing approach (#8695) fix(connector): [Access Worldpay] correct enum deserialization for payment responses for (#8689) chore(version): 2025.07.21.0
pixincreate
added a commit
that referenced
this pull request
Jul 22, 2025
…ayload-recurring * 'main' of github.com:juspay/hyperswitch: (48 commits) fix(connector): Add Trustpay in Authentication Providers Config (#8622) refactor(connector): [Adyen] map ssn and session validity for Pix (#8702) feat(core): Implement UCS kill switch for emergency fallback (#8651) fix(openapi): Added Error Response Schema for Status Code 400 (#8684) feat(connector): Add template code for breadpay (#8655) chore(version): 2025.07.21.1 refactor(payments): fetch payment method information in attempts list api v2 and add custom billing connector template (#8681) fix(router): Make v2 endpoints follow standard naming conventions (#8630) fix(connector): [Cybersource] Add type_selection_indicator as 1 for all cards (#8663) feat(routing): Add API key auth for decision engine endpoints (#8640) feat(authentication): Added eligibility flow for modular authentication (#8431) feat(connector): [BLACKHAWKNETWORK] Add Template Code (#8632) fix: remove straight through routing from routing approach (#8695) fix(connector): [Access Worldpay] correct enum deserialization for payment responses for (#8689) chore(version): 2025.07.21.0 feat(debit_routing): add debit routing support for apple pay (#8673) refactor(router): decrypt the wallet token before the debit routing call (#8598) chore: update org retrieve api response to include org type (#8660) feat(routing): Add routing evaluation rule endpoint and related flow (#8656) fix(connector): [AUTHORIZEDOTNET] Added Invoice Number Fix (#8685) ...
pixincreate
added a commit
that referenced
this pull request
Jul 22, 2025
…acilitapay-mca-metadata * 'main' of github.com:juspay/hyperswitch: fix(connector): Add Trustpay in Authentication Providers Config (#8622) refactor(connector): [Adyen] map ssn and session validity for Pix (#8702) feat(core): Implement UCS kill switch for emergency fallback (#8651) fix(openapi): Added Error Response Schema for Status Code 400 (#8684) feat(connector): Add template code for breadpay (#8655) chore(version): 2025.07.21.1 refactor(payments): fetch payment method information in attempts list api v2 and add custom billing connector template (#8681) fix(router): Make v2 endpoints follow standard naming conventions (#8630) fix(connector): [Cybersource] Add type_selection_indicator as 1 for all cards (#8663) feat(routing): Add API key auth for decision engine endpoints (#8640) feat(authentication): Added eligibility flow for modular authentication (#8431) feat(connector): [BLACKHAWKNETWORK] Add Template Code (#8632) fix: remove straight through routing from routing approach (#8695) fix(connector): [Access Worldpay] correct enum deserialization for payment responses for (#8689)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Fixes Worldpay refused payment responses not populating error codes and messages.
Changes in this PR
WorldpayPaymentResponseFields
enum variants to prioritizeRefusedResponse
overAuthorizedResponse
Additional Changes
Motivation and Context
Fixes enum deserialization issue where refused responses were incorrectly matched as
AuthorizedResponse
due to variant ordering, causingrefusalCode
andrefusalDescription
fields to be silently ignored.How did you test it?
Things to be verified
Acceptance criteria
1. Create a refused 3DS payment
cURL
Response
Open and complete the payment
Fetch payment
cURL
Response
2. Create a refused Non3DS payment
cURL
Response
3. Create a successful Non3DS payment
cURL
Response
4. Create a successful 3DS payment
cURL
Response
Open and complete payment
Fetch payment
cURL
Response
Checklist
cargo +nightly fmt --all
cargo clippy