Skip to content

fix(routing): remove frm rule migration support as it is not supported in DE #8448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

fix(routing): remove frm rule migration support as it is not supported in DE #8448

merged 1 commit into from
Jun 24, 2025

Conversation

jagan-jaya
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

As FRM routing is not supported in DE we can remove support for it from DE migration endpoint

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Compilation and cypress is working as expected.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jun 24, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/core/routing.rs  0% smaller

@jagan-jaya jagan-jaya linked an issue Jun 24, 2025 that may be closed by this pull request
remove frm rule migration support as it is not supported in DE #8449
Closed
@jagan-jaya jagan-jaya marked this pull request as ready for review June 24, 2025 10:59
@jagan-jaya jagan-jaya requested a review from a team as a code owner June 24, 2025 10:59
@jagan-jaya jagan-jaya changed the title fix(routing): remove frm migration support as it is not supported in DE fix(routing): remove frm rule migration support as it is not supported in DE Jun 24, 2025
@likhinbopanna likhinbopanna enabled auto-merge June 24, 2025 11:07
@likhinbopanna likhinbopanna added this pull request to the merge queue Jun 24, 2025
Merged via the queue into main with commit fdacec4 Jun 24, 2025
23 of 27 checks passed
@likhinbopanna likhinbopanna deleted the fix-routing-migration branch June 24, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prajjwalkumar17 prajjwalkumar17 prajjwalkumar17 approved these changes

+1 more reviewer

@Chethan-rao Chethan-rao Chethan-rao approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove frm rule migration support as it is not supported in DE
4 participants
@jagan-jaya @prajjwalkumar17 @Chethan-rao @likhinbopanna