Skip to content

Conversation

pixincreate
Copy link
Member

@pixincreate pixincreate commented Jun 23, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR implements refund flow for JPMorgan connector. Connector returns Authorized state (Pending). Post RSync call, the status gets updated to Success.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

The connector lacked this basic feature until now. Closes #8435

How did you test it?

Updated Cypress tests:

image

There exist an issue from the connector where it returns same transaction_id (connector_transaction_id) every single time which we have no control. Because of this, refunds tend to exceed the maximum refundable amount resulting in 4xx as shown below:

image image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by just clippy && jut clippy_v2
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@pixincreate pixincreate added this to the June 2025 Release milestone Jun 23, 2025
@pixincreate pixincreate self-assigned this Jun 23, 2025
@pixincreate pixincreate requested review from a team as code owners June 23, 2025 17:30
@pixincreate pixincreate added A-CI-CD Area: Continuous Integration/Deployment A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jun 23, 2025
Copy link

semanticdiff-com bot commented Jun 23, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/hyperswitch_connectors/src/connectors/jpmorgan/transformers.rs  38% smaller
  crates/hyperswitch_connectors/src/connectors/jpmorgan.rs  29% smaller
  cypress-tests/cypress/e2e/configs/Payment/Jpmorgan.js  0% smaller

@pixincreate pixincreate changed the title feat: implement refund flow for jpmorgan feat(connector): [jpmorgan] implement refund flow Jun 23, 2025
@likhinbopanna likhinbopanna added this pull request to the merge queue Jun 25, 2025
Merged via the queue into main with commit cf92e1a Jun 25, 2025
16 of 20 checks passed
@likhinbopanna likhinbopanna deleted the connector/jpmorgan-refunds branch June 25, 2025 07:01
@pixincreate pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI-CD Area: Continuous Integration/Deployment A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Implement Refund for JPMorgan
4 participants