Skip to content

Conversation

dgeee13
Copy link
Contributor

@dgeee13 dgeee13 commented Jun 13, 2025

… implemented as required in the code to optional

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Change connector fields that are currently implemented as required in the code to optional - billing address and card holder name are optional fields

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

After Changes

make /payments without optional field billing.address

curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_T1HKwjm5U0WlfjAgmTAcoE2ejpTsm5J02qCBBqYTNVkHZ7KY5ZKkz2HLfR26Mz5r' \ --data '{ "amount": 600, "amount_to_capture": 600, "currency": "EUR", "confirm": true, "capture_method": "automatic", "authentication_type": "no_three_ds", "payment_method": "card", "payment_method_type": "credit", "payment_method_data": { "card": { "card_cvc": "123", "card_exp_month": "01", "card_exp_year": "50", "card_number": "4242424242424242" } } }'

Screenshot 2025-06-13 at 3 28 27 PM

Before Changes

make /payments without optional field billing.address
Screenshot 2025-06-13 at 3 32 54 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

… implemented as required in the code to optional
@dgeee13 dgeee13 self-assigned this Jun 13, 2025
@dgeee13 dgeee13 requested a review from a team as a code owner June 13, 2025 10:10
Copy link

semanticdiff-com bot commented Jun 13, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/hyperswitch_connectors/src/connectors/archipel/transformers.rs  58% smaller

@likhinbopanna likhinbopanna added this pull request to the merge queue Jun 13, 2025
Merged via the queue into main with commit cfd0b07 Jun 13, 2025
17 of 23 checks passed
@likhinbopanna likhinbopanna deleted the archipelOptionalFields branch June 13, 2025 13:01
dgeee13 added a commit that referenced this pull request Jun 17, 2025
… implemented as required in the code to optional (#8342)

Co-authored-by: Debarati Ghatak <[email protected]>
dgeee13 added a commit that referenced this pull request Jun 17, 2025
… implemented as required in the code to optional (#8342)

Co-authored-by: Debarati Ghatak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants