fix: correct error for env not found

[Shailesh-714]

Type of Change

• Bugfix
• New feature
• Enhancement
• Refactoring
• Dependency updates
• Documentation
• CI/CD

Description

PR : #8238 calls for a env variable before the .env file is sourced in the scripts/setup.sh file.
This PR fixes the above mentioned issue and handles the health checks using flags instead of exit codes, enabling the script to proceed further without getting terminated.

Additional Changes

• This PR modifies the API contract
• This PR modifies application configuration/environment variables
• This PR modifies the database schema

Motivation and Context

How did you test it?

1. Run scripts/setup.sh.
2. If it prompts ports already in use, enter y to proceed.
3. Choose 1) Standard Setup in setup options.
4. If setup is successful, you will get this final output:

5. Try signing in to control center using the default credentials provided.

Checklist

• I formatted the code cargo +nightly fmt --all
• I addressed lints thrown by cargo clippy
• I reviewed the submitted code
• I added unit tests for my changes where possible

Summary by CodeRabbit

• Chores
  • Improved the setup process to ensure environment variables are loaded after configuration is updated.

[semanticdiff-com]

Review changes with  

[coderabbitai]

Walkthrough

The change adjusts the order of operations in the scripts/setup.sh script so that the .oneclick-setup.env file is sourced only after the setup_config function is called. This ensures that environment variables are loaded after the configuration file is generated or updated.

Changes

File(s)	Change Summary
scripts/setup.sh	Moved sourcing of .oneclick-setup.env to after the setup_config function.

Poem

A script hops forward, neat and keen,
First it sets up, then loads the scene.
With envs in place, the path is clear,
Each variable now appears right here!
Bash bunnies cheer, the order’s right—
Setup, then source, in morning light.
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5ce2ab2 and 6ed6d41.

📒 Files selected for processing (1)

• scripts/setup.sh (1 hunks)

⏰ Context from checks skipped due to timeout of 900000ms (8)

• GitHub Check: Spell check PR title
• GitHub Check: Validate generated OpenAPI spec file
• GitHub Check: Check wasm build
• GitHub Check: Verify consistency of migrations with schema.rs file
• GitHub Check: Run Cypress tests
• GitHub Check: Check compilation for V2 features
• GitHub Check: Run tests on stable toolchain (ubuntu-latest)
• GitHub Check: Check compilation on MSRV toolchain (ubuntu-latest)

🔇 Additional comments (1)

scripts/setup.sh (1)

372-372: Ensure environment file is sourced after creation
Moving source .oneclick-setup.env to immediately follow setup_config guarantees the file exists before sourcing and eliminates the “env not found” error.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[SanchithHegde]

Won't this mean that we would print access info even if is_success is false? Is that the intended / expected behavior?

[Shailesh-714]

Yeah, its intended because checks can fail due to soft errors and these will be later altered when port allocation flow is added to it.