-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(payment_methods): add external_vault_details
for payments v2 sdk session call
#8003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
None, | ||
merchant_context.get_merchant_key_store(), | ||
profile.get_id(), | ||
"", // This is a placeholder for the connector name, which is not used in this context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we instead create a v2 fn with no connector_name in the input params?
pub async fn get_merchant_connector_account_v2( | ||
state: &SessionState, | ||
merchant_id: &id_type::MerchantId, | ||
creds_identifier: Option<&str>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: there's no creds_identitifer in V2 flows
@@ -176,15 +176,15 @@ pub struct ConnectorCustomerData { | |||
pub phone: Option<Secret<String>>, | |||
pub name: Option<Secret<String>>, | |||
pub preprocessing_id: Option<String>, | |||
pub payment_method_data: PaymentMethodData, | |||
pub payment_method_data: Option<PaymentMethodData>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are moving mandate to Optional, if it is in the response, people would have already written conditions based on this. Can you verify if there is no changes in the api contract.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This struct is being used to propagate request data to connectors. The only place this is affecting is transformers.rs of facilitapay and the logic is added to handle in there
…nktransfer * 'main' of github.com:juspay/hyperswitch: (211 commits) feat(tokenio): Add OpenBanking Redirection Flow (#8152) fix: Unified scarf setup (#8238) feat(health): Health check for Decision engine (#8243) chore: Update apple pay currency filter configs (#8217) refactor(customers_v2): Remove merchant reference id from v2 customer update (#7879) chore(version): 2025.06.09.0 chore(postman): update Postman collection files ci(postman): add tunnel collection to postman tests (#8269) feat(connector): Added recurring payments support for split payments in Stripe (#8271) feat(connector): [STRIPE] Added Connector Tokenization Flow for Cards (#8248) refactor(core): introduce new field in payment_intent to handle longer return_url (#8135) fix(connector): [AUTHORIZEDOTNET] Remove country PM filters (#8278) refactor(config): redact config urls for hyperswitch vault (#8276) feat(vsaas): enable onboarding of Standard Merchant Accounts in Platform Organization (#8231) feat(router): add three_ds decision rule execute api (#8148) feat(router): Save payment method on payments confirm (V2) (#8090) ci(cypress): Add Airwallex Connector Test (#8187) feat(payment_methods): add `external_vault_details` for payments v2 sdk session call (#8003) fix(connector): [facilitapay] cpf is a required field (#8274) fix: Fixed spell check (#8227) ...
Type of Change
Description
vault_session_details
field to session's response for vault sdk initiationclient_secret
andsession_id
, this is done in sdk session call of paymentsAdditional Changes
Motivation and Context
How did you test it?
Tested through Postman:
Create an MCA with Hyperswitch Vault:
Enable vault SDK through Business Profile:
Create a Payment Intent:
Create SDK session call using the payment_id:
The response should look like below:
Checklist
cargo +nightly fmt --all
cargo clippy