refactor(open_router): call elimination routing of open router if enabled instead of dynamo

[Chethan-rao]

Type of Change

• Bugfix
• New feature
• Enhancement
• Refactoring
• Dependency updates
• Documentation
• CI/CD

Description

This pull request introduces significant updates to the dynamic routing logic, focusing on enhancing the success-based routing mechanism and improving the integration with the "open router" service. Key changes include the addition of a new helper method, refactoring of existing methods for better clarity, and updates to the routing logic to streamline decision-making.

Enhancements to Dynamic Routing Logic:

• Added a new method is_success_rate_routing_enabled in DynamicRoutingAlgorithmRef to determine if success-based routing is enabled, improving readability and encapsulation. (crates/api_models/src/routing.rs)
• Modified the perform_open_routing function to consolidate success-based and elimination routing into a single API call, simplifying the logic for deciding gateways. (crates/router/src/core/payments/routing.rs) [1] [2]

Integration with Open Router:

• Introduced a new helper function update_gateway_score_helper_with_open_router to handle gateway score updates when routing through the open router. This replaces the previous push_metrics_with_update_window_for_success_based_routing in relevant contexts. (crates/router/src/core/routing/helpers.rs) [1] [2]
• Renamed methods like update_success_rate_score_with_open_router to update_gateway_score_with_open_router and perform_success_based_routing_with_open_router to perform_decide_gateway_call_with_open_router for better alignment with their functionality. (crates/router/src/core/payments/routing.rs) [1] [2] [3]

Refactor and Cleanup:

• Refactored the payment_response_update_tracker function to include conditional logic for routing decisions based on the open router's configuration, ensuring better error handling and logging. (crates/router/src/core/payments/operations/payment_response.rs) [1] [2]
• Reintroduced the push_metrics_with_update_window_for_success_based_routing function with a more focused implementation, while retaining the original logic for backward compatibility. (crates/router/src/core/routing/helpers.rs)

These changes collectively improve the maintainability, readability, and functionality of the dynamic routing system, particularly in scenarios involving success-based routing and open router integration.

Additional Changes

• This PR modifies the API contract
• This PR modifies the database schema
• This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Since the feature cannot be deployed in main pod, this can be tested through custom pod which I can help with

Checklist

• I formatted the code cargo +nightly fmt --all
• I addressed lints thrown by cargo clippy
• I reviewed the submitted code
• I added unit tests for my changes where possible

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
crates/router/src/core/payments/routing.rs	82% smaller
crates/router/src/core/payments/operations/payment_response.rs	82% smaller
crates/router/src/core/routing/helpers.rs	45% smaller
crates/router/src/core/payments.rs	31% smaller
crates/router/src/core/errors.rs	4% smaller
crates/api_models/src/routing.rs	0% smaller