refactor(router): make error_type generic in domain_models inorder to avoid conversion of errors in storage_impl

[jagan-jaya]

Type of Change

• Bugfix
• New feature
• Enhancement
• Refactoring
• Dependency updates
• Documentation
• CI/CD

Description

Currently we are creating the interfaces for CRUD operations for each resource in hyperswitch_domain_models which returns a result of Result<Resource, hyperswitch_domain_models::errors::StorageError> and we are implementing them in storage_impl which is expected to return hyperswitch_domain_models::errors::StorageError.

Instead we are making the result in hyperswitch_domain_models to Result<Resource, Self::Error> by which anyone implementing the trait can pass their own error type, this way we can directly return storage_impl::errors::StorageError directly. So a conversion from DomainStorageError to StorageError is not needed.

Datastorage error can be completely replaced with StorageError as both have conversion of ApplicationErrorResponse and other required errors

Additional Changes

• This PR modifies the API contract
• This PR modifies the database schema
• This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

1. No business logic is changed
2. Compilation of v1 and v2 working fine and all the cypress tests passes

Checklist

• I formatted the code cargo +nightly fmt --all
• I addressed lints thrown by cargo clippy
• I reviewed the submitted code
• I added unit tests for my changes where possible

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
crates/router/src/core/payments.rs	82% smaller
crates/storage_impl/src/utils.rs	77% smaller
crates/router/src/events.rs	75% smaller
crates/storage_impl/src/mock_db/payout_attempt.rs	72% smaller
crates/storage_impl/src/payouts/payout_attempt.rs	69% smaller
crates/storage_impl/src/mock_db/payouts.rs	59% smaller
crates/router/src/core/errors.rs	58% smaller
crates/storage_impl/src/payment_method.rs	57% smaller
crates/storage_impl/src/payouts/payouts.rs	50% smaller
crates/storage_impl/src/mock_db/payment_attempt.rs	50% smaller
crates/storage_impl/src/database/store.rs	26% smaller
crates/router/src/core/errors/utils.rs	16% smaller
crates/storage_impl/src/kv_router_store.rs	12% smaller
crates/payment_methods/src/state.rs	5% smaller
crates/storage_impl/src/lookup.rs	3% smaller
crates/storage_impl/src/mock_db.rs	2% smaller
crates/router/src/db/user/sample_data.rs	2% smaller
crates/storage_impl/src/payments/payment_attempt.rs	1% smaller
crates/router/src/services.rs	1% smaller
api-reference-v2/openapi_spec.json	0% smaller
api-reference/openapi_spec.json	0% smaller
crates/analytics/src/opensearch.rs	0% smaller
crates/hyperswitch_domain_models/src/errors.rs	0% smaller
crates/hyperswitch_domain_models/src/payment_methods.rs	0% smaller
crates/hyperswitch_domain_models/src/payments/payment_attempt.rs	0% smaller
crates/hyperswitch_domain_models/src/payments/payment_intent.rs	0% smaller
crates/hyperswitch_domain_models/src/payouts/payout_attempt.rs	0% smaller
crates/hyperswitch_domain_models/src/payouts/payouts.rs	0% smaller
crates/router/src/core/errors/user/sample_data.rs	0% smaller
crates/router/src/core/payment_methods/tokenize/payment_method_executor.rs	0% smaller
crates/router/src/core/payments/helpers.rs	0% smaller
crates/router/src/core/payments/operations/payment_status.rs	0% smaller
crates/router/src/core/payouts/helpers.rs	0% smaller
crates/router/src/core/payouts/validator.rs	0% smaller
crates/router/src/db.rs	0% smaller
crates/router/src/db/kafka_store.rs	0% smaller
crates/storage_impl/src/errors.rs	0% smaller
crates/storage_impl/src/lib.rs	0% smaller
crates/storage_impl/src/mock_db/payment_intent.rs	0% smaller
crates/storage_impl/src/payments/payment_intent.rs	0% smaller