ci: minor refactors and improvements #7308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll` to install supported tools
…ariable as sparse index is enabled by default
…e to network issues
SanchithHegde
added
A-CI-CD
|
Review changes with Changed Files
|
pixincreate
reviewed
Feb 19, 2025
Comment on lines
211
to
+215
| # - name: Install cargo-nextest | ||
| # uses: baptiste0928/cargo-install@v2.2.0 | ||
| # uses: taiki-e/install-action@v2 | ||
| # with: | ||
| # crate: cargo-nextest | ||
| # tool: cargo-nextest | ||
| # checksum: true |
There was a problem hiding this comment.
we can just remove the commented ones since they're unused? or do we have it kept as a reference?
pixincreate
approved these changes
Feb 19, 2025
prasunna09
approved these changes
Feb 20, 2025
SanchithHegde
removed
the
S-waiting-on-review
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
pixincreate
added a commit
to pixincreate/hyperswitch
that referenced
this pull request
Feb 25, 2025
…tion-fork * 'main' of github.com:juspay/hyperswitch: feat(core): [Card Testing Guard] Implement Card Testing Guard (juspay#7108) chore(version): 2025.02.25.0 ci: minor refactors and improvements (juspay#7308) fix(connector): [NMI] Added enum for Void Reason (juspay#7221) ci(CI-pr): disable `cargo-hack` step for hotfix PRs (juspay#7334)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR includes minor refactors and improvements to our CI workflows:
baptiste0928/cargo-installwithtaiki-e/install-actionto install tools. This is done because if the binary is not available in cache, thebaptiste0928/cargo-installaction builds it from source, which can take a longer amount of time, as compared totaiki-e/install-action, which should be deterministic since it pulls pre-built binaries from releases.CARGO_REGISTRIES_CRATES_IO_PROTOCOLenvironment variable to enable sparse index, but since it is enabled by default on recent Rust versions, I've removed it.postgres:latestandredis:latestwithpostgres:alpineandredis:alpinerespectively, to slightly reduce bandwidth used when pulling images.workflow_dispatchtrigger, which hasn't been used in quite a while, so I've removed it.CI-pushworkflow was missing some environment variables that allowed us to handle flaky CI failures due to network issues, so I copied them from theCI-prworkflow.Motivation and Context
Minor improvements and dependency updates to the CI workflows.
How did you test it?
N/A
Checklist
cargo +nightly fmt --allcargo clippy