Skip to content

Conversation

Aprabhat19
Copy link
Contributor

@Aprabhat19 Aprabhat19 commented Feb 4, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • This PR consists of the process tracker flow for Psync and Review Tasks

  • Psync Task is created if a payment’s status is Processing with an active attempt_id

    Action: match attempt status and update the process tracker status based on that.
    Finish the current task

  • This PR also includes changes in the execute_payment workflow where , we record an attempt first and then call the proxy api to perform the payments

Screenshot 2025-03-12 at 6 25 37 PM
  • if the payment fails it would retry in a given interval for given number of default retries
Screenshot 2025-03-13 at 2 07 42 PM
  • If thePayment goes to processing , a PSYNC_WORKFLOW Is Scheduled

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

  • Create a MA and a MCA for payments and an MCA for billing connectors with a threshold to retry the payments
  • When a failure webhook is received a payment intent is created and multiple attempts are created for the external failed payments
  • Once the threshold is reached the payment is inserted to the Process tracker, which is picked after the schedule time
  • A payment attempt is created, which could either be Succeed or Failed
  • iF payment is processing a Psync-Workflow is to be created

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Aprabhat19 Aprabhat19 added the A-process-tracker Area: Process tracker label Feb 4, 2025
@Aprabhat19 Aprabhat19 self-assigned this Feb 4, 2025
Copy link

semanticdiff-com bot commented Feb 4, 2025

@Aprabhat19 Aprabhat19 requested a review from jarnura February 4, 2025 07:25
@Aprabhat19 Aprabhat19 marked this pull request as ready for review February 4, 2025 07:49
@Aprabhat19 Aprabhat19 requested review from a team as code owners February 4, 2025 07:49
srujanchikke
srujanchikke previously approved these changes Apr 22, 2025
jarnura
jarnura previously approved these changes Apr 23, 2025
))
.await?;
}
Err(_) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log the error don't discard

jarnura
jarnura previously approved these changes Apr 24, 2025
srujanchikke
srujanchikke previously approved these changes Apr 24, 2025
@likhinbopanna likhinbopanna added this pull request to the merge queue Apr 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 29, 2025
@Aprabhat19 Aprabhat19 dismissed stale reviews from jarnura and srujanchikke via 356d5f5 April 29, 2025 11:54
@likhinbopanna likhinbopanna added this pull request to the merge queue Apr 30, 2025
Merged via the queue into main with commit 9e9a922 Apr 30, 2025
20 of 24 checks passed
@likhinbopanna likhinbopanna deleted the psyn-task-workflow branch April 30, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-process-tracker Area: Process tracker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants