fix(cypress): address cybersource redirection inconsistency #7057

pixincreate · 2025-01-17T11:02:32Z

Type of Change

Description

enabled video recording for tests that fail
cybersource connector in github ci, randomly goes through frictionless flow without challenge which results in certain expected elements to go missing resulting in respective tests to fail
this pr forces cybersource to use frictionless card for 3ds
remove adyenplatform connector from running in github ci

closes #7058

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

ci checks

How did you test it?

this issue is not reproducible in local but only in github ci. so, the ci check should never fail!

Checklist

I formatted the code npm run format
I addressed lints thrown by npm run lint
I reviewed the submitted code
I added unit tests for my changes where possible

force it to wait until the page loads. this is more sophisticated, reliable, and safer

semanticdiff-com · 2025-01-17T11:02:35Z

Review changes with

Changed Files

File	Status
cypress-tests/cypress/support/redirectionHandler.js	48% smaller
.github/workflows/cypress-tests-runner.yml	Unsupported file format
cypress-tests/.gitignore	Unsupported file format
cypress-tests/cypress.config.js	0% smaller
cypress-tests/cypress/e2e/PaymentUtils/Cybersource.js	0% smaller
cypress-tests/cypress/support/e2e.js	0% smaller

…urce-inconsistency * 'main' of github.com:juspay/hyperswitch: chore(version): 2025.01.20.0 fix(relay): populate connector metadata in the refunds flow (#7045) fix(connector): [NETCETERA] add accept-language in browser_information for netcetera authentication request (#7059) chore: Update readme with juspay's vision, product offering, architecture diagram, setup steps and output (#7024) chore: update creds (#7054)

pixincreate · 2025-01-20T17:07:08Z

.github/workflows/cypress-tests-runner.yml

@@ -14,7 +14,7 @@ env:
  CARGO_INCREMENTAL: 0
  CARGO_NET_RETRY: 10
  PAYMENTS_CONNECTORS: "cybersource stripe"
-  PAYOUTS_CONNECTORS: "adyenplatform wise"
+  PAYOUTS_CONNECTORS: "wise"


we've removed adyenplatform from running since connector throws 5xx

pixincreate · 2025-01-20T17:08:56Z

cypress-tests/cypress.config.js

+      on("after:spec", (spec, results) => {
+        if (results && results.video) {
+          // Do we have failures for any retry attempts?
+          const failures = results.tests.some((test) =>
+            test.attempts.some((attempt) => attempt.state === "failed")
+          );
+          if (!failures) {
+            // delete the video if the spec passed and no tests retried
+            fs.unlinkSync(results.video);
+          }
+        }
+      });


we've enabled video recording in L63. Since we do not want to keep the whole recording but only for the tests that fail, this section is necessary to keep the report clean

pixincreate · 2025-01-20T17:09:17Z

cypress-tests/cypress/e2e/PaymentUtils/Cybersource.js

@@ -12,7 +12,7 @@ const successfulNo3DSCardDetails = {
 };

 const successfulThreeDSTestCardDetails = {
-  card_number: "4000000000001091",
+  card_number: "4000000000002701",


this card forces cybersource 3ds to go through the friction less flow

pixincreate · 2025-01-20T17:12:11Z

cypress-tests/cypress/support/redirectionHandler.js

+  } else if (connectorId === "cybersource") {
+    cy.url({ timeout: TIMEOUT }).should("include", expected_url.origin);
+    return;


frictionless flow.

@likhinbopanna, do you think we need return here?

Not necessarily

…urce-inconsistency * 'main' of github.com:juspay/hyperswitch: refactor(payment-link): use shouldRemoveBeforeUnloadEvents flag for handling removal of beforeunload events through SDK (#7072) refactor(router): refactor ctp flow to fetch mca_id and get the connector creds instead of connector_name (#6859)

Co-authored-by: likhinbopanna <[email protected]>

This reverts commit f74edab.

SanchithHegde

CI workflow changes look good to me!

This reverts commit d315396.

This reverts commit 8dc2897.

pixincreate · 2025-01-21T06:24:09Z

cypress-tests/cypress/support/redirectionHandler.js

      });
+  } else if (connectorId === "cybersource") {
+    cy.url({ timeout: TIMEOUT }).should("include", expected_url.origin);
+    return; // this is mandatory, else refunds section will fail with unhandled promise rejections even though it is handled


i want this to be removed. will consider this as a separate pr

…d-memory-cache * 'main' of github.com:juspay/hyperswitch: (38 commits) fix(cypress): uncaught exceptions thrown by `hyperswitch.io` (#7092) ci(workflows): Add code coverage reporting for v2 (#6884) chore(version): 2025.01.23.0 refactor: [CYBERSOURCE, BANKOFAMERICA, WELLSFARGO] Move code to crate hyperswitch_connectors (#6908) Documentation edits made through Mintlify web editor chore: enable 128-column-tables feature for diesel crate (#6857) feat(connector): [ADYEN ] Consume transaction id for PaymentsPreProcessing error (#7061) chore(version): 2025.01.22.0 feat(routing): Integrate global success rates (#6950) feat(email): Add mailhog by default in docker-compose for local smtp server (#6869) refactor: check allowed payment method types in enabled options (#7019) feat(router): add payment method-specific features to connector feature list (#6963) Refactor: Customer email and browser Information (#7034) feat(connectors): fiuu,novalnet,worldpay - extend NTI flows (#6946) fix(cypress): address cybersource redirection inconsistency (#7057) chore(version): 2025.01.21.0 refactor(payment-link): use shouldRemoveBeforeUnloadEvents flag for handling removal of beforeunload events through SDK (#7072) refactor(router): refactor ctp flow to fetch mca_id and get the connector creds instead of connector_name (#6859) chore(version): 2025.01.20.0 fix(relay): populate connector metadata in the refunds flow (#7045) ...

pixincreate added 2 commits January 17, 2025 16:25

fix(cypress): address cybersource redirection inconsistency

c075818

force it to wait until the page loads. this is more sophisticated, reliable, and safer

chore: address lint

ff09794

pixincreate added A-CI-CD Area: Continuous Integration/Deployment S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jan 17, 2025

pixincreate added this to the December 2024 Release milestone Jan 17, 2025

pixincreate self-assigned this Jan 17, 2025

pixincreate added 3 commits January 17, 2025 17:32

chore: refactor

0b98318

chore: lints

baf6c73

revert

93f78de

SanchithHegde modified the milestones: December 2024 Release, January 2025 Release Jan 19, 2025

pixincreate added 6 commits January 20, 2025 12:12

try changing card

81764de

change card again

520e28a

record video of point of failure

088d258

add a check for frictionless flow

2f8db29

refactor

88bf267

pixincreate commented Jan 20, 2025

View reviewed changes

pixincreate added 2 commits January 20, 2025 22:42

revert e2e changes

f74edab

pixincreate force-pushed the fix-cybersource-inconsistency branch from 39e1481 to f74edab Compare January 20, 2025 17:15

hyperswitch-bot bot and others added 3 commits January 20, 2025 17:16

chore(cypress): run formatter and address lints

2366f9f

re-add commit 39e14812cca350480090fd566e140754832bbfa9

8bbb140

Co-authored-by: likhinbopanna <[email protected]>

remove

f19b547

pixincreate requested review from likhinbopanna and SanchithHegde January 20, 2025 17:37

pixincreate marked this pull request as ready for review January 20, 2025 17:38

pixincreate requested review from a team as code owners January 20, 2025 17:38

likhinbopanna previously approved these changes Jan 20, 2025

View reviewed changes

Revert "revert e2e changes"

fb542fe

This reverts commit f74edab.

pixincreate dismissed likhinbopanna’s stale review via fb542fe January 20, 2025 18:20

pixincreate requested a review from likhinbopanna January 20, 2025 18:23

likhinbopanna previously approved these changes Jan 20, 2025

View reviewed changes

SanchithHegde previously approved these changes Jan 20, 2025

View reviewed changes

pixincreate added 2 commits January 21, 2025 07:01

see if this fixes ci

6781da7

see if this fixes ci

b035c3f

pixincreate dismissed stale reviews from SanchithHegde and likhinbopanna via b035c3f January 21, 2025 01:38

pixincreate requested review from SanchithHegde and likhinbopanna January 21, 2025 01:38

pixincreate added 5 commits January 21, 2025 08:11

remove return for proper validations

8dc2897

chore: address lints

d315396

Revert "chore: address lints"

24a6c6a

This reverts commit d315396.

Revert "remove return for proper validations"

d41f5b4

This reverts commit 8dc2897.

just return false.

a02270d

SanchithHegde approved these changes Jan 21, 2025

View reviewed changes

pixincreate commented Jan 21, 2025

View reviewed changes

likhinbopanna approved these changes Jan 21, 2025

View reviewed changes

likhinbopanna removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 21, 2025

likhinbopanna added this pull request to the merge queue Jan 21, 2025

Merged via the queue into main with commit 90c932a Jan 21, 2025
18 of 20 checks passed

likhinbopanna deleted the fix-cybersource-inconsistency branch January 21, 2025 07:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(cypress): address cybersource redirection inconsistency #7057

fix(cypress): address cybersource redirection inconsistency #7057

Uh oh!

pixincreate commented Jan 17, 2025 •

edited

Loading

Uh oh!

semanticdiff-com bot commented Jan 17, 2025 •

edited

Loading

Uh oh!

pixincreate Jan 20, 2025

Uh oh!

pixincreate Jan 20, 2025

Uh oh!

pixincreate Jan 20, 2025 •

edited

Loading

Uh oh!

pixincreate Jan 20, 2025

Uh oh!

likhinbopanna Jan 20, 2025

Uh oh!

SanchithHegde left a comment

Uh oh!

pixincreate Jan 21, 2025

Uh oh!

Uh oh!

Uh oh!

fix(cypress): address cybersource redirection inconsistency #7057

fix(cypress): address cybersource redirection inconsistency #7057

Uh oh!

Conversation

pixincreate commented Jan 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

Uh oh!

semanticdiff-com bot commented Jan 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pixincreate Jan 20, 2025

Choose a reason for hiding this comment

Uh oh!

pixincreate Jan 20, 2025

Choose a reason for hiding this comment

Uh oh!

pixincreate Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pixincreate Jan 20, 2025

Choose a reason for hiding this comment

Uh oh!

likhinbopanna Jan 20, 2025

Choose a reason for hiding this comment

Uh oh!

SanchithHegde left a comment

Choose a reason for hiding this comment

Uh oh!

pixincreate Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pixincreate commented Jan 17, 2025 •

edited

Loading

semanticdiff-com bot commented Jan 17, 2025 •

edited

Loading

pixincreate Jan 20, 2025 •

edited

Loading