Skip to content

feat(connector): [COINGATE] Add Template PR #7052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 6, 2025
Merged

feat(connector): [COINGATE] Add Template PR #7052

merged 3 commits into from
Feb 6, 2025

Conversation

awasthi21
Copy link
Contributor

@awasthi21 awasthi21 commented Jan 17, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Template PR

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Testing Not needed

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@awasthi21 awasthi21 requested review from a team as code owners January 17, 2025 05:58
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jan 17, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/connector.rs  98% smaller
  crates/hyperswitch_connectors/src/connectors.rs  88% smaller
  crates/router/src/core/payments/flows.rs  20% smaller
  crates/hyperswitch_connectors/src/default_implementations.rs  18% smaller
  crates/hyperswitch_connectors/src/default_implementations_v2.rs  18% smaller
  config/config.example.toml Unsupported file format
  config/deployments/integration_test.toml Unsupported file format
  config/deployments/production.toml Unsupported file format
  config/deployments/sandbox.toml Unsupported file format
  config/development.toml Unsupported file format
  config/docker_compose.toml Unsupported file format
  crates/common_enums/src/connector_enums.rs  0% smaller
  crates/hyperswitch_connectors/src/connectors/coingate.rs  0% smaller
  crates/hyperswitch_connectors/src/connectors/coingate/transformers.rs  0% smaller
  crates/hyperswitch_interfaces/src/configs.rs  0% smaller
  crates/router/src/types/api.rs  0% smaller
  crates/router/src/types/transformers.rs  0% smaller
  crates/router/tests/connectors/coingate.rs  0% smaller
  crates/test_utils/src/connector_auth.rs  0% smaller
  loadtest/config/development.toml Unsupported file format
  scripts/add_connector.sh Unsupported file format

@awasthi21 awasthi21 self-assigned this Jan 17, 2025
@awasthi21 awasthi21 added the A-connector-integration Area: Connector integration label Jan 17, 2025
deepanshu-iiitu
deepanshu-iiitu requested changes Jan 17, 2025
View reviewed changes
crates/hyperswitch_connectors/src/connectors/coingate/test.rs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this file to crates/router/tests/connectors
Also rename it to coingate.rs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@awasthi21 awasthi21 force-pushed the 8138-featconnector-coingate-add-template-pr-for-coingate branch 2 times, most recently from 6862d74 to 2ae5023 Compare January 22, 2025 05:56
@awasthi21 awasthi21 force-pushed the 8138-featconnector-coingate-add-template-pr-for-coingate branch 2 times, most recently from 1f347c8 to 0a4c236 Compare January 24, 2025 08:36
@codecov Codecov
Copy link

codecov bot commented Jan 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 505 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@a9a1ded). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../hyperswitch_connectors/src/connectors/coingate.rs 0.00% 412 Missing ⚠️
...connectors/src/connectors/coingate/transformers.rs 0.00% 93 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7052   +/-   ##
=======================================
  Coverage        ?    4.11%           
=======================================
  Files           ?     1012           
  Lines           ?   207908           
  Branches        ?        0           
=======================================
  Hits            ?     8548           
  Misses          ?   199360           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ShankarSinghC
ShankarSinghC previously approved these changes Jan 27, 2025
View reviewed changes
SanchithHegde
SanchithHegde previously approved these changes Jan 27, 2025
View reviewed changes
@awasthi21 awasthi21 force-pushed the 8138-featconnector-coingate-add-template-pr-for-coingate branch from 54a33b9 to 06995e9 Compare February 6, 2025 06:11
@awasthi21 awasthi21 force-pushed the 8138-featconnector-coingate-add-template-pr-for-coingate branch from 4337135 to 07726d4 Compare February 6, 2025 06:21
@likhinbopanna likhinbopanna added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit dddb1b0 Feb 6, 2025
21 of 24 checks passed
@likhinbopanna likhinbopanna deleted the 8138-featconnector-coingate-add-template-pr-for-coingate branch February 6, 2025 14:33
pixincreate added a commit that referenced this pull request Feb 7, 2025
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into ci/make-amo…
b6b3dfe 
…unt-configurable

* 'main' of github.com:juspay/hyperswitch: (37 commits)
  refactor(router): add display_name field to connector feature api  (#7121)
  ci(cypress): Add Tests for Customer Deletion and Psync flows (#7158)
  feat(connector): [DataTrans] ADD 3DS Flow (#6026)
  chore(version): 2025.02.07.0
  chore(connectors): [fiuu] update pm_filters for apple pay and google pay (#7182)
  feat(router): add `organization_id` in authentication table and add it in authentication events (#7168)
  fix(dashboard_metadata): mask `poc_email` and `data_value` for DashboardMetadata (#7130)
  feat(core): Add support for v2 payments get intent using merchant reference id (#7123)
  refactor(customer): return redacted customer instead of error (#7122)
  fix(connector): handle unexpected error response from bluesnap connector (#7120)
  feat(routing): Contract based routing integration  (#6761)
  refactor(dynamic_fields): dynamic fields for Adyen and Stripe, renaming klarnaCheckout, WASM for KlarnaCheckout (#7015)
  feat(connector): [COINGATE] Add Template PR  (#7052)
  chore(roles): remove redundant variant from PermissionGroup (#6985)
  refactor(router): store `network_transaction_id` for `off_session` payments irrespective of the `is_connector_agnostic_mit_enabled` config (#7083)
  chore(connector): [Fiuu] log keys in the PSync response (#7189)
  ci(cypress): fix nmi and paypal (#7173)
  chore(version): 2025.02.06.0
  chore(postman): update Postman collection files
  feat(connector): [Deutschebank] Add Access Token Error struct (#7127)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@deepanshu-iiitu deepanshu-iiitu deepanshu-iiitu approved these changes

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@ShankarSinghC ShankarSinghC ShankarSinghC approved these changes

Assignees

@awasthi21 awasthi21

Labels
A-connector-integration Area: Connector integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@awasthi21 @SanchithHegde @deepanshu-iiitu @sai-harsha-vardhan @ShankarSinghC @likhinbopanna