-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(webhooks): adyen - consume and update connector's network_transaction_id in payment_methods #6738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction_id in payment_methods
Changed Files
|
srujanchikke
reviewed
Dec 4, 2024
2 tasks
jarnura
requested changes
Dec 5, 2024
jarnura
previously approved these changes
Dec 5, 2024
srujanchikke
previously approved these changes
Dec 5, 2024
ShankarSinghC
previously approved these changes
Dec 5, 2024
72a5e90
jarnura
approved these changes
Dec 5, 2024
srujanchikke
approved these changes
Dec 5, 2024
ShankarSinghC
approved these changes
Dec 5, 2024
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-connector-compatibility
Area: Connector compatibility
A-core
Area: Core flows
A-mandates
Area: Mandate Flows
A-webhooks
Area: Webhook flows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Described in #6719
This PR introduces below changes
get_network_txn_id
fn in IncomingWebhook traitnetwork_transaction_id
inpayment_methods
tableAdditional Changes
Motivation and Context
Helps persist network transaction IDs for connectors in case it was not present in Authorize or Capture responses but instead sent in the webhook!
How did you test it?
network_tx_reference
(field in Adyen) is not returned in Authorize or Capture responsenetwork_transaction_id
is populated after receiving webhooksChecklist
cargo +nightly fmt --all
cargo clippy