feat(connector): [DEUTSCHEBANK, FIUU ] Handle 2xx errors given by Connector #6727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
dgeee13
changed the title
dgeee13
changed the title
srujanchikke
reviewed
Dec 4, 2024
| Ok(Self { | ||
| response: Err(ErrorResponse { | ||
| code: response_status.clone(), | ||
| message: refund_data.reason.clone().unwrap_or("".to_owned()), |
There was a problem hiding this comment.
can we map this to NO_ERROR_MESSAGE in unwrap ?
deepanshu-iiitu
requested changes
Dec 4, 2024
Comment on lines
395
to
398
| let response_code = item.response.rc.clone(); | ||
| let is_response_success = is_response_success(response_code.clone()); | ||
|
|
||
| if is_response_success { |
There was a problem hiding this comment.
Suggested change
| let response_code = item.response.rc.clone(); | |
| let is_response_success = is_response_success(response_code.clone()); | |
| if is_response_success { | |
| if is_response_success(item.response.rc.clone()) { |
Comment on lines
417
to
418
| let error_reason = item.response.message.clone(); | ||
| let response = Err(get_error_response( | ||
| response_code.clone(), | ||
| error_reason, | ||
| item.http_code, | ||
| )); | ||
|
|
||
| Ok(Self { | ||
| status: common_enums::AttemptStatus::Failure, | ||
| response, | ||
| ..item.data | ||
| }) |
There was a problem hiding this comment.
Suggested change
| let error_reason = item.response.message.clone(); | |
| let response = Err(get_error_response( | |
| response_code.clone(), | |
| error_reason, | |
| item.http_code, | |
| )); | |
| Ok(Self { | |
| status: common_enums::AttemptStatus::Failure, | |
| response, | |
| ..item.data | |
| }) | |
| Ok(Self { | |
| status: common_enums::AttemptStatus::Failure, | |
| response: Err(get_error_response( | |
| response_code.clone(), | |
| item.response.message.clone(), | |
| item.http_code, | |
| )), | |
| ..item.data | |
| }) |
Comment on lines
359
to
370
| let error_reason = item.response.message.clone(); | ||
| let response = Err(get_error_response( | ||
| response_code.clone(), | ||
| error_reason, | ||
| item.http_code, | ||
| )); | ||
|
|
||
| Ok(Self { | ||
| status: common_enums::AttemptStatus::Failure, | ||
| response, | ||
| ..item.data | ||
| }) |
There was a problem hiding this comment.
Suggested change
| let error_reason = item.response.message.clone(); | |
| let response = Err(get_error_response( | |
| response_code.clone(), | |
| error_reason, | |
| item.http_code, | |
| )); | |
| Ok(Self { | |
| status: common_enums::AttemptStatus::Failure, | |
| response, | |
| ..item.data | |
| }) | |
| Ok(Self { | |
| status: common_enums::AttemptStatus::Failure, | |
| response: Err(get_error_response( | |
| response_code.clone(), | |
| item.response.message.clone(), | |
| item.http_code, | |
| )), | |
| ..item.data | |
| }) |
Comment on lines
612
to
615
| let response_code = item.response.rc.clone(); | ||
| let is_response_success = is_response_success(response_code.clone()); | ||
|
|
||
| if is_response_success { |
There was a problem hiding this comment.
Suggested change
| let response_code = item.response.rc.clone(); | |
| let is_response_success = is_response_success(response_code.clone()); | |
| if is_response_success { | |
| if is_response_success(item.response.rc.clone()) { |
Comment on lines
634
to
630
| let error_reason = item.response.message.clone(); | ||
| let response = Err(get_error_response( | ||
| response_code.clone(), | ||
| error_reason, | ||
| item.http_code, | ||
| )); | ||
|
|
||
| Ok(Self { | ||
| status: common_enums::AttemptStatus::Failure, | ||
| response, | ||
| ..item.data | ||
| }) |
There was a problem hiding this comment.
Suggested change
| let error_reason = item.response.message.clone(); | |
| let response = Err(get_error_response( | |
| response_code.clone(), | |
| error_reason, | |
| item.http_code, | |
| )); | |
| Ok(Self { | |
| status: common_enums::AttemptStatus::Failure, | |
| response, | |
| ..item.data | |
| }) | |
| Ok(Self { | |
| status: common_enums::AttemptStatus::Failure, | |
| response: Err(get_error_response( | |
| response_code.clone(), | |
| item.response.message.clone(), | |
| item.http_code, | |
| )), | |
| ..item.data | |
| }) |
Comment on lines
899
to
902
| let response_code = item.response.rc.clone(); | ||
| let is_response_success = is_response_success(response_code.clone()); | ||
|
|
||
| let status = if is_response_success { |
There was a problem hiding this comment.
Suggested change
| let response_code = item.response.rc.clone(); | |
| let is_response_success = is_response_success(response_code.clone()); | |
| let status = if is_response_success { | |
| let status = if is_response_success(item.response.rc.clone()) { |
Comment on lines
923
to
936
| Some(enums::RefundStatus::Failure) => { | ||
| let error_reason = item.response.message.clone(); | ||
| let response = Err(get_error_response( | ||
| response_code.clone(), | ||
| error_reason, | ||
| item.http_code, | ||
| )); | ||
|
|
||
| Ok(Self { | ||
| status: common_enums::AttemptStatus::Failure, | ||
| response, | ||
| ..item.data | ||
| }) | ||
| } |
There was a problem hiding this comment.
Suggested change
| Some(enums::RefundStatus::Failure) => { | |
| let error_reason = item.response.message.clone(); | |
| let response = Err(get_error_response( | |
| response_code.clone(), | |
| error_reason, | |
| item.http_code, | |
| )); | |
| Ok(Self { | |
| status: common_enums::AttemptStatus::Failure, | |
| response, | |
| ..item.data | |
| }) | |
| } | |
| Some(enums::RefundStatus::Failure) => { | |
| Ok(Self { | |
| status: common_enums::AttemptStatus::Failure, | |
| response: Err(get_error_response( | |
| response_code.clone(), | |
| item.response.message.clone(), | |
| item.http_code, | |
| )), | |
| ..item.data | |
| }) | |
| } |
Comment on lines
1022
to
1023
| let response_status = refund_data.status; | ||
| let refund_status = match response_status.as_str() { |
There was a problem hiding this comment.
Suggested change
| let response_status = refund_data.status; | |
| let refund_status = match response_status.as_str() { | |
| let refund_status = match refund_data.status.as_str() { |
| Ok(Self { | ||
| response: Err(ErrorResponse { | ||
| code: response_status.clone(), | ||
| message: refund_data.reason.clone().unwrap_or("".to_owned()), |
There was a problem hiding this comment.
Suggested change
| message: refund_data.reason.clone().unwrap_or("".to_owned()), | |
| message: refund_data.reason.clone().unwrap_or(consts::NO_ERROR_MESSAGE), |
| @@ -991,6 +991,7 @@ pub struct FiuuRefundSuccessResponse { | |||
| #[serde(rename = "RefundID")] | |||
| refund_id: i64, | |||
| status: String, | |||
| reason: Option<String>, | |||
There was a problem hiding this comment.
Are we getting this reason in response. Did you test it?
There was a problem hiding this comment.
no @deepanshu-iiitu , not able to test this . reason is an optional field and will only come in unsucessful refund cases . Not able to test this unsuccesful refund flow locally
There was a problem hiding this comment.
You could reach out to @awasthi21 to check if he knows how to trigger unsuccessful refunds.
dgeee13
force-pushed
the
handle2xxErrorDB
branch
2 times, most recently
from
d27ada7 to
f0239cd
Compare
deepanshu-iiitu
requested changes
Dec 5, 2024
| @@ -991,6 +991,7 @@ pub struct FiuuRefundSuccessResponse { | |||
| #[serde(rename = "RefundID")] | |||
| refund_id: i64, | |||
| status: String, | |||
| reason: Option<String>, | |||
There was a problem hiding this comment.
You could reach out to @awasthi21 to check if he knows how to trigger unsuccessful refunds.
dgeee13
force-pushed
the
handle2xxErrorDB
branch
from
f0239cd to
72a8e5e
Compare
deepanshu-iiitu
approved these changes
Dec 5, 2024
srujanchikke
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
DeutscheBankin case of 2xx errors, because it is currently not handled for 2xx errors. Error message is only consumed for 4xx and 5xx.Fiuuin case of 2xx errors only in case ofrefunds. In all other cases where 2xx errors are thrown, code is already handling it.Additional Changes
Motivation and Context
How did you test it?
Tested manually using Postman
Test Doc
Checklist
cargo +nightly fmt --allcargo clippy