feat(connector): [Novalnet] Integrate wallets Paypal and Googlepay #6370

dgeee13 · 2024-10-18T12:58:07Z

Type of Change

Description

Integrated Googlepay and Paypal for Novalnet
Integrated mandates for Googlepay and Paypal

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

https://github.com/juspay/hyperswitch-cloud/issues/6731

How did you test it?

Tested manually.
Test cases:

Googlepay payment
- manual
- automatic
- mandates
Paypal
- manual
- automatic
- mandates

Manual Testing Doc

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

semanticdiff-com · 2024-10-18T12:58:09Z

Review changes with SemanticDiff.

Analyzed 2 of 5 files.

Overall, the semantic diff is 13% smaller than the GitHub diff.

	Filename	Status
✔️	crates/hyperswitch_connectors/src/connectors/novalnet.rs	71.43% smaller
✔️	crates/hyperswitch_connectors/src/connectors/novalnet/transformers.rs	10.87% smaller
❔	crates/connector_configs/toml/development.toml	Unsupported file format
❔	crates/connector_configs/toml/production.toml	Unsupported file format
❔	crates/connector_configs/toml/sandbox.toml	Unsupported file format

srujanchikke · 2024-10-21T06:41:02Z

crates/hyperswitch_connectors/src/connectors/novalnet.rs

            Ok(api_models::webhooks::ObjectReferenceId::RefundId(
-                api_models::webhooks::RefundIdType::ConnectorRefundId(notif.event.tid.to_string()),
+                api_models::webhooks::RefundIdType::ConnectorRefundId(parent_tid.to_string()),


what is the difference between event.parent_tid and event.tid ?

according to docs,
event.tid - The TID which is relevant to this event.
event.parent_tid - During the course of followup events like chargebacks, credit entry etc.., this field will contain the value of the original/initial transaction TID.

I have removed this change. Not needed.

srujanchikke · 2024-10-21T07:02:04Z

crates/hyperswitch_connectors/src/connectors/novalnet/transformers.rs

                let transaction_status = item
                    .response
                    .transaction
+                    .clone()


can we pass reference here ?

deepanshu-iiitu · 2024-10-21T07:45:11Z

crates/hyperswitch_connectors/src/connectors/novalnet.rs

@@ -195,8 +195,11 @@ impl ConnectorValidation for Novalnet {
        pm_type: Option<enums::PaymentMethodType>,
        pm_data: PaymentMethodData,
    ) -> CustomResult<(), errors::ConnectorError> {
-        let mandate_supported_pmd: HashSet<PaymentMethodDataType> =
-            HashSet::from([PaymentMethodDataType::Card]);
+        let mandate_supported_pmd: HashSet<PaymentMethodDataType> = HashSet::from([


Please add the changes in crates/connector_configs/toml as well

deepanshu-iiitu · 2024-10-21T07:47:02Z

crates/hyperswitch_connectors/src/connectors/novalnet.rs

            Ok(api_models::webhooks::ObjectReferenceId::RefundId(
-                api_models::webhooks::RefundIdType::ConnectorRefundId(notif.event.tid.to_string()),
+                api_models::webhooks::RefundIdType::ConnectorRefundId(parent_tid.to_string()),


Are we supposed to populate ConnectorRefundId with parent_tid?

no, I have removed this code. notif.event.tid should work.

deepanshu-iiitu · 2024-10-21T07:52:03Z

@cookieg13
Did you test Google Pay and Paypal Flows?

dgeee13 · 2024-10-21T11:28:27Z

@cookieg13 Did you test Google Pay and Paypal Flows?

yes tested locally, webhooks and mandates are tested too

Gnanasundari24 · 2024-10-23T12:04:03Z

@cookieg13 Can you add the response aswell then only will get to know whether its worked or not. and add the mandate req and res also

dgeee13 · 2024-10-24T05:37:50Z

@cookieg13 Can you add the response aswell then only will get to know whether its worked or not. and add the mandate req and res also

added testing doc with req and responses in readme

dgeee13 requested a review from a team as a code owner October 18, 2024 12:58

dgeee13 changed the title ~~Novalnet wallets~~ feat(connector): [Novalnet] integrate Paypal and Googlepay wallets Oct 18, 2024

dgeee13 self-assigned this Oct 18, 2024

dgeee13 added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement labels Oct 18, 2024

dgeee13 changed the title ~~feat(connector): [Novalnet] integrate Paypal and Googlepay wallets~~ feat(connector): [Novalnet] Integrate Paypal and Googlepay wallets Oct 18, 2024

dgeee13 changed the title ~~feat(connector): [Novalnet] Integrate Paypal and Googlepay wallets~~ feat(connector): [Novalnet] Integrate wallets Paypal and Googlepay Oct 18, 2024

srujanchikke reviewed Oct 21, 2024

View reviewed changes

deepanshu-iiitu requested changes Oct 21, 2024

View reviewed changes

dgeee13 force-pushed the novalnetWallets branch from de7f584 to 8190de3 Compare October 21, 2024 10:59

dgeee13 requested review from deepanshu-iiitu and srujanchikke October 21, 2024 11:19

srujanchikke previously approved these changes Oct 21, 2024

View reviewed changes

dgeee13 dismissed srujanchikke’s stale review via c1b4501 October 21, 2024 11:31

dgeee13 force-pushed the novalnetWallets branch 2 times, most recently from c1b4501 to a415817 Compare October 21, 2024 11:55

dgeee13 requested a review from srujanchikke October 21, 2024 11:57

srujanchikke previously approved these changes Oct 21, 2024

View reviewed changes

dgeee13 requested a review from srujanchikke October 21, 2024 12:11

deepanshu-iiitu previously approved these changes Oct 21, 2024

View reviewed changes

Gnanasundari24 enabled auto-merge October 24, 2024 06:58

dgeee13 added 4 commits October 24, 2024 16:48

add mandates for card pmt

7ac06d0

add formatting fixes

f21af78

resolve pr comments

f818fd8

resolve comments

9ea4a9a

dgeee13 and others added 15 commits October 24, 2024 16:48

Remove mandate creds from cypress test file

f2c9283

Add formatting fixes

b31ec81

remove phone number as mandatory field for payments request

7193b7a

add webhook fns

c6f8e3c

add mapping fixes for webhook

fd6c046

add fixes

8b0da2c

resolve pr comments

59036c8

chore: run formatter

28b23bb

add wallets flow

01c6afa

add paypal wallet

28fe794

add googlepay wallet

2ec011c

add nightly changes

7e19635

remove unnecessary code

416fe0b

add mandates

87a72d5

resolve cargo nightly issues

ab46d80

dgeee13 dismissed stale reviews from deepanshu-iiitu and srujanchikke via a398832 October 24, 2024 11:21

dgeee13 force-pushed the novalnetWallets branch from a415817 to a398832 Compare October 24, 2024 11:21

dgeee13 requested a review from a team as a code owner October 24, 2024 11:21

resolve comments

17bd60c

dgeee13 force-pushed the novalnetWallets branch from a398832 to 17bd60c Compare October 24, 2024 11:35

dgeee13 requested a review from deepanshu-iiitu October 24, 2024 11:40

srujanchikke approved these changes Oct 24, 2024

View reviewed changes

deepanshu-iiitu approved these changes Oct 24, 2024

View reviewed changes

Gnanasundari24 added this pull request to the merge queue Oct 24, 2024

dgeee13 removed the request for review from a team October 24, 2024 13:08

Merged via the queue into main with commit 673b869 Oct 24, 2024
17 checks passed

Gnanasundari24 deleted the novalnetWallets branch October 24, 2024 13:35

dgeee13 mentioned this pull request Nov 12, 2024

feat(connector): [Novalnet] Add supported currencies #6547

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(connector): [Novalnet] Integrate wallets Paypal and Googlepay #6370

feat(connector): [Novalnet] Integrate wallets Paypal and Googlepay #6370

Uh oh!

dgeee13 commented Oct 18, 2024 •

edited

Loading

Uh oh!

semanticdiff-com bot commented Oct 18, 2024 •

edited

Loading

Uh oh!

srujanchikke Oct 21, 2024

Uh oh!

dgeee13 Oct 21, 2024

Uh oh!

srujanchikke Oct 21, 2024

Uh oh!

deepanshu-iiitu Oct 21, 2024

Uh oh!

deepanshu-iiitu Oct 21, 2024

Uh oh!

dgeee13 Oct 21, 2024

Uh oh!

deepanshu-iiitu commented Oct 21, 2024

Uh oh!

dgeee13 commented Oct 21, 2024

Uh oh!

Gnanasundari24 commented Oct 23, 2024 •

edited

Loading

Uh oh!

dgeee13 commented Oct 24, 2024

Uh oh!

Uh oh!

Uh oh!

feat(connector): [Novalnet] Integrate wallets Paypal and Googlepay #6370

feat(connector): [Novalnet] Integrate wallets Paypal and Googlepay #6370

Uh oh!

Conversation

dgeee13 commented Oct 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

Uh oh!

semanticdiff-com bot commented Oct 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

srujanchikke Oct 21, 2024

Choose a reason for hiding this comment

Uh oh!

dgeee13 Oct 21, 2024

Choose a reason for hiding this comment

Uh oh!

srujanchikke Oct 21, 2024

Choose a reason for hiding this comment

Uh oh!

deepanshu-iiitu Oct 21, 2024

Choose a reason for hiding this comment

Uh oh!

deepanshu-iiitu Oct 21, 2024

Choose a reason for hiding this comment

Uh oh!

dgeee13 Oct 21, 2024

Choose a reason for hiding this comment

Uh oh!

deepanshu-iiitu commented Oct 21, 2024

Uh oh!

dgeee13 commented Oct 21, 2024

Uh oh!

Gnanasundari24 commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dgeee13 commented Oct 24, 2024

Uh oh!

Uh oh!

Uh oh!

dgeee13 commented Oct 18, 2024 •

edited

Loading

semanticdiff-com bot commented Oct 18, 2024 •

edited

Loading

Gnanasundari24 commented Oct 23, 2024 •

edited

Loading