-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix(router): make customer details None in the Psync
flow if the customer is deleted
#5732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review changes with SemanticDiff. Analyzed 5 of 5 files. Overall, the semantic diff is 17% smaller than the GitHub diff.
|
Narayanbhat166
previously approved these changes
Aug 29, 2024
should we send the customer details ( which are redacted ). This behaviour, where we are saying that the customer id is null is not consistent. If |
…-customer/psync-flow
…ails in the psync flow
…yperswitch into fix-customer/psync-flow
…-customer/psync-flow
Narayanbhat166
approved these changes
Sep 3, 2024
SanchithHegde
approved these changes
Sep 3, 2024
pixincreate
added a commit
that referenced
this pull request
Sep 5, 2024
* 'main' of github.com:juspay/hyperswitch: feat(customer_v2): Add customer V2 delete api (#5518) chore(version): 2024.09.05.0 feat(user_roles): get user role details (#5777) feat(users): Add profile level invites (#5793) refactor(router): profile based routes for payouts (#5794) Feat(connector): [Fiuu] Add Card Flows (#5786) fix(cypress): fix fiservemea configs for cypress (#5772) fix(cypress): `api_key` check in cypress (#5787) feat(payment_methods_v2): Implemented Diesel and Domain models for v2 (#5700) fix(payout): query for getting a list of active payout IDs (#5771) refactor(router): remove admin v2 intermediate features (#5780) feat(revert): populate payment method details in payments response (#5785) chore(version): 2024.09.04.0 fix(connector): skip 3DS in `network_transaction_id` flow for cybersource (#5781) refactor(euclid): check the authenticity of profile_id being used (#5647) feat(analytics): refactor and introduce analytics APIs to accommodate OrgLevel, MerchantLevel and ProfileLevel authentication (#5729) fix(router): make customer details None in the `Psync` flow if the customer is deleted (#5732) feat(connector): [DEUTSCHE] Add template code (#5774) chore(version): 2024.09.03.1 fix(router): send post message to window.parent instead of window.top in external 3ds flow (#5778)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
If the customer is deleted after the payment is done the payments retrieve will fail as the customer details are redacted. But we should be able to retrieve a payment even is the customer details are redacted.
This pr contains the changes that will set the customer details to
None
if the customer details are redacted during thePsync
.Additional Changes
Motivation and Context
How did you test it?
-> Make a card payment
-> Delete the customer
-> force sync
-> sync
-> Create a 3DS payment
-> Perform the 3DS action
-> Delete the customer
-> Retrieve the payment
-> Create a payment with manual capture
-> Delete the customer
-> Retrieve payment
-> Guest customer
Create a payment
Payments retrieve
-> Customer details are sent in the customer object
-> Delete a customer and retrieve a payment
Checklist
cargo +nightly fmt --all
cargo clippy