Skip to content

Conversation

JeevaRamu0104
Copy link
Contributor

@JeevaRamu0104 JeevaRamu0104 commented Aug 27, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Add wasm support for additional Merchant Account Data
image

image
image

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@JeevaRamu0104 JeevaRamu0104 requested a review from a team as a code owner August 27, 2024 09:39
Copy link

semanticdiff-com bot commented Aug 27, 2024

Review changes with SemanticDiff.

Analyzed 1 of 4 files.

Filename Status
crates/connector_configs/toml/development.toml Unsupported file format
crates/connector_configs/toml/production.toml Unsupported file format
crates/connector_configs/toml/sandbox.toml Unsupported file format
✔️ crates/connector_configs/src/connector.rs Analyzed

@JeevaRamu0104 JeevaRamu0104 self-assigned this Aug 27, 2024
@JeevaRamu0104 JeevaRamu0104 added the S-blocked Status: Blocked on something else or other implementation work label Aug 27, 2024
@hyperswitch-bot hyperswitch-bot bot requested a review from a team as a code owner August 27, 2024 09:42
@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Aug 27, 2024
@JeevaRamu0104 JeevaRamu0104 removed the M-api-contract-changes Metadata: This PR involves API contract changes label Aug 27, 2024
…ithub.com:juspay/hyperswitch into add-wasm-support-for-connector-additional-details
@Sarthak1799
Copy link
Contributor

Can you add screenshots for collection of connector_recipient_id as well? @JeevaRamu0104

@Sarthak1799
Copy link
Contributor

A few changes -

  • Can we have the account_data in dropdown of Open Banking Recipient Data to be renamed to Bank Account Data so that it is more intuitive.
  • Can we rename the Account Data on top of the iban dropdown to Bank scheme, we can have the sepa and bacs as dropdown options for Bank scheme. For sepa we can display the iban related info and for bacs the bacs related info would work.
    @JeevaRamu0104

@JeevaRamu0104 JeevaRamu0104 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed E-easy Effort: Should be easy to implement and would make a good first PR and removed S-blocked Status: Blocked on something else or other implementation work labels Aug 30, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Sep 2, 2024
@likhinbopanna likhinbopanna removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Sep 2, 2024
Merged via the queue into main with commit 45929f2 Sep 2, 2024
14 checks passed
@likhinbopanna likhinbopanna deleted the add-wasm-support-for-connector-additional-details branch September 2, 2024 13:25
pixincreate added a commit that referenced this pull request Sep 3, 2024
…config-fix

* 'main' of github.com:juspay/hyperswitch:
  feat: add profile_id authentication for business profile update and list (#5673)
  chore(version): 2024.09.03.0
  feat(user): implement invitations api (#5769)
  feat(connector): [Adyenplatform] add webhooks for payout (#5749)
  refactor(v2_migrations): re-organize v2 migrations (#5760)
  chore: add wasm support for connector additional details (#5712)
  refactor(connector): Move globepay, powertranz, tsys, worldline to hyperswitch_connectors (#5758)
  fix(cypress): fix cypress throwing error when `connectorId` is not passed and miscellaneous fixes (#5746)
  chore: fix typos (#5766)
  refactor(business_profile): change id for business profile (#5748)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy Effort: Should be easy to implement and would make a good first PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Plaid as Payment Processor -
5 participants