refactor(router): domain and diesel model changes for merchant_connector_account create v2 flow #5462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperswitch-bot
bot
added
the
M-api-contract-changes
hyperswitch-bot
bot
removed
the
M-api-contract-changes
sai-harsha-vardhan
added
the
S-waiting-on-review
sai-harsha-vardhan
changed the title
jarnura
requested changes
Jul 30, 2024
| pub connector_account_details: Encryption, | ||
| pub disabled: Option<bool>, | ||
| #[diesel(deserialize_as = super::OptionalDieselArray<serde_json::Value>)] | ||
| pub payment_methods_enabled: Option<Vec<serde_json::Value>>, |
There was a problem hiding this comment.
Suggested change
| pub payment_methods_enabled: Option<Vec<serde_json::Value>>, | |
| pub payment_methods_enabled: Option<Vec<pii::SecretSerdeValue>>, |
| pub connector_type: storage_enums::ConnectorType, | ||
| pub metadata: Option<pii::SecretSerdeValue>, | ||
| pub connector_label: Option<String>, | ||
| pub frm_configs: Option<Secret<serde_json::Value>>, |
There was a problem hiding this comment.
Suggested change
| pub frm_configs: Option<Secret<serde_json::Value>>, | |
| pub frm_configs: Option<Secret<pii::SecretSerdeValue>>, |
| pub modified_at: time::PrimitiveDateTime, | ||
| pub connector_webhook_details: Option<pii::SecretSerdeValue>, | ||
| #[diesel(deserialize_as = super::OptionalDieselArray<pii::SecretSerdeValue>)] | ||
| pub frm_config: Option<Vec<Secret<serde_json::Value>>>, |
There was a problem hiding this comment.
Suggested change
| pub frm_config: Option<Vec<Secret<serde_json::Value>>>, | |
| pub frm_config: Option<Vec<Secret<pii::SecretSerdeValue>>>, |
There was a problem hiding this comment.
There are two frm configs we should remove one which is deprecated.
There was a problem hiding this comment.
Address all these in other related types too (like MerchantConnectorAccountNew, update types, update internal types)
jarnura
previously approved these changes
Aug 1, 2024
prajjwalkumar17
previously approved these changes
Aug 1, 2024
ThisIsMani
previously approved these changes
Aug 1, 2024
apoorvdixit88
previously approved these changes
Aug 1, 2024
sai-harsha-vardhan
removed this pull request from the merge queue due to a manual request
sai-harsha-vardhan
dismissed stale reviews from apoorvdixit88, ThisIsMani, prajjwalkumar17, and jarnura
via
9f626fe
sai-harsha-vardhan
requested review from
jarnura,
prajjwalkumar17,
apoorvdixit88 and
ThisIsMani
jarnura
approved these changes
Aug 1, 2024
prajjwalkumar17
approved these changes
Aug 1, 2024
apoorvdixit88
approved these changes
Aug 1, 2024
SanchithHegde
removed
the
S-waiting-on-review
pixincreate
added a commit
that referenced
this pull request
Aug 5, 2024
…ypress-x2 * 'main' of github.com:juspay/hyperswitch: refactor(cypress): pass `connector_type` externally (#5522) refactor(router): refactor merchant_connector update v2 flow (#5484) feat(router): add accept language header middleware (#5500) chore(version): 2024.08.05.0 chore(postman): update Postman collection files fix(pm_auth): Added mca status check in pml (#5421) refactor(payment_methods): List the Payment Methods for Merchant , based on the connector type (#4909) fix(router): [Iatapay] make error status and error message optional (#5382) chore(version): 2024.08.02.0 feat(business_profile): introduce domain models for business profile v1 and v2 APIs (#5497) feat(auth): Add `profile_id` in `AuthenticationData` (#5492) feat(core): accept business profile in core functions for payments, refund, payout and disputes (#5498) refactor(router): domain and diesel model changes for merchant_connector_account create v2 flow (#5462) fix(open_payment_links): send displaySavedPaymentMethods as false explicitly for open payment links (#5501) refactor(role): determine level of role entity (#5488)
pixincreate
added a commit
that referenced
this pull request
Aug 5, 2024
* 'main' of github.com:juspay/hyperswitch: (37 commits) fix(connector): Fixed status mapping for Plaid (#5525) feat(core): accept profile_id in merchant_account, connectors and customers core functions (#5505) refactor(auth): Pass `profile_id` from the auth to core functions (#5520) refactor(routing): Refactor api v2 routes for deactivating and retrieving the routing config (#5478) refactor(cypress): pass `connector_type` externally (#5522) refactor(router): refactor merchant_connector update v2 flow (#5484) feat(router): add accept language header middleware (#5500) chore(version): 2024.08.05.0 chore(postman): update Postman collection files fix(pm_auth): Added mca status check in pml (#5421) refactor(payment_methods): List the Payment Methods for Merchant , based on the connector type (#4909) fix(router): [Iatapay] make error status and error message optional (#5382) chore(version): 2024.08.02.0 feat(business_profile): introduce domain models for business profile v1 and v2 APIs (#5497) feat(auth): Add `profile_id` in `AuthenticationData` (#5492) feat(core): accept business profile in core functions for payments, refund, payout and disputes (#5498) refactor(router): domain and diesel model changes for merchant_connector_account create v2 flow (#5462) fix(open_payment_links): send displaySavedPaymentMethods as false explicitly for open payment links (#5501) refactor(role): determine level of role entity (#5488) feat(cypress): add corner cases (#5481) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
domain and diesel model changes for merchant_connector_account create v2 flow
Additional Changes
Motivation and Context
How did you test it?
Tested manually
Sanity MCA Create and subsequent flows like payment / capture / refund with v1 version
Sanity Sessions flow
Sanity Incoming webhooks flow
Sanity MCA create / update / retrieve flows
Checklist
cargo +nightly fmt --allcargo clippy