feat(events): add metadata info to events #4875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsampras
added
A-framework
2 tasks
…ort-for-sending-additional-metadata-in-the-messaginginterface
su-shivanshmathur
approved these changes
Jun 5, 2024
SanchithHegde
approved these changes
Jun 5, 2024
| _timestamp: PrimitiveDateTime, | ||
| ) -> error_stack::Result<(), EventsError> | ||
| where | ||
| T: Message<Class = Self::MessageClass> + ErasedMaskSerialize, | ||
| { | ||
| logger::info!(event =? data.masked_serialize().unwrap_or_else(|e| serde_json::json!({"error": e.to_string()})), event_type =? data.get_message_class(), event_id =? data.identifier(), log_type =? "event"); | ||
| logger::info!(event =? data.masked_serialize().unwrap_or_else(|e| serde_json::json!({"error": e.to_string()})), event_type =? data.get_message_class(), event_id =? data.identifier(), log_type =? "event", metadata = ?metadata); |
There was a problem hiding this comment.
This can be simplified. Optional change.
Suggested change
| logger::info!(event =? data.masked_serialize().unwrap_or_else(|e| serde_json::json!({"error": e.to_string()})), event_type =? data.get_message_class(), event_id =? data.identifier(), log_type =? "event", metadata = ?metadata); | |
| logger::info!(event =? data.masked_serialize().unwrap_or_else(|e| serde_json::json!({"error": e.to_string()})), event_type =? data.get_message_class(), event_id =? data.identifier(), log_type =? "event", ?metadata); |
ivor11
approved these changes
Jun 6, 2024
Gnanasundari24
deleted the
4472-feature-add-support-for-sending-additional-metadata-in-the-messaginginterface
branch
pixincreate
added a commit
that referenced
this pull request
Jun 7, 2024
…out-fix * 'main' of github.com:juspay/hyperswitch: refactor(connector): convert init payment flow to preprocessing flow for shift4 (#4884) ci(cypress): Add billing address for bank redirects (#4903) refactor(openapi): move openapi to a separate folder (#4859) chore(version): 2024.06.07.0 refactor(outgoing_webhooks): raise errors in the analytics pipeline in case of API client errors or non-2xx responses (#4894) chore(config): [MIFINITY] add configs for Mifinity in WASM (#4895) feat(router): add `acquirer_country_code` in acquirer_details and send it in netcetera authentication flow (#4835) refactor(connector): convert init payment flow to preprocessing flow for nuvei (#4878) feat(connector): [MIFINITY] Implement payment flows and Mifinity payment method (#4592) fix(connectors): [BOA/CYBS] make avs code optional (#4898) feat(events): add metadata info to events (#4875)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy