-
Notifications
You must be signed in to change notification settings - Fork 4.2k
refactor(users): Changes for Home and Signout APIs for TOTP Redis flows #4851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pub is_two_factor_auth_setup: bool, | ||
pub recovery_codes_left: Option<usize>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recovery_codes_left: Some(_)
represents is_two_factor_auth_setup: true
.
Lets try to simplify if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be done once we remove totp_status
from users.
Add test case for signout changes as well |
…atus_pt * 'main' of github.com:juspay/hyperswitch: chore(version): 2024.06.04.0 fix: include client_version and client_source in retried payments (#4826) refactor(users): Changes for Home and Signout APIs for TOTP Redis flows (#4851) feat(users): Create config for TOTP Issuer (#4776) feat(multitenancy): add support for multitenancy and handle the same in router, producer, consumer, drainer and analytics (#4630) feat(connector): [AUTHORIZEDOTNET] Support payment_method_id in recurring mandate payment (#4841) refactor(connector): airwallex convert init payment to preprocessing (#4842) feat(router): send `three_ds_requestor_url` in authentication_response for external 3ds flow (#4828) feat(consolidated-kafka-events): add consolidated kafka payment events (#4798) refactor(connector): [Klarna] Add shipping Address in Klarna Session and Payment Request (#4836) fix(connector): make few fields optional in struct NetceteraErrorDetails (#4827) chore(cypress): remove logs that expose `globalState` (#4844)
* 'main' of github.com:juspay/hyperswitch: feat(cypress): Add service level testing for Payouts (#4744) feat(auth): Create and use `SinglePurposeOrLoginTokenAuth` (#4830) refactor(connector): [Adyen] handle redirection error response (#4862) refactor(api_models): rename Card struct for payouts to avoid overrides in auto generated open API spec (#4861) chore(version): 2024.06.04.1 fix(connector): [Adyen]add required fields for afterpay clearpay (#4858) chore(version): 2024.06.04.0 fix: include client_version and client_source in retried payments (#4826) refactor(users): Changes for Home and Signout APIs for TOTP Redis flows (#4851) feat(users): Create config for TOTP Issuer (#4776) feat(multitenancy): add support for multitenancy and handle the same in router, producer, consumer, drainer and analytics (#4630) feat(connector): [AUTHORIZEDOTNET] Support payment_method_id in recurring mandate payment (#4841) refactor(connector): airwallex convert init payment to preprocessing (#4842) feat(router): send `three_ds_requestor_url` in authentication_response for external 3ds flow (#4828) feat(consolidated-kafka-events): add consolidated kafka payment events (#4798)
Type of Change
Description
After this PR, Home API will send the details about the user's 2FA, specifically weather user has completed 2FA setup and number of recovery codes left for him.
Additional Changes
Motivation and Context
Closes #4848
How did you test it?
Home API
Signout
Hit Signout API
200 OK
Signin with the same user again
Take the token from the above response and hit 2FA status API
Checklist
cargo +nightly fmt --all
cargo clippy