feat(users): implement force set and force change password #4564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoorvdixit88
added
C-feature
apoorvdixit88
changed the title
ThisIsMani
reviewed
May 7, 2024
Comment on lines
350
to
375
| #[cfg(feature = "olap")] | ||
| #[async_trait] | ||
| impl<A> AuthenticateAndFetch<(), A> for SinglePurposeJWTAuth | ||
| where | ||
| A: AppStateInfo + Sync, | ||
| { | ||
| async fn authenticate_and_fetch( | ||
| &self, | ||
| request_headers: &HeaderMap, | ||
| state: &A, | ||
| ) -> RouterResult<((), AuthenticationType)> { | ||
| let payload = parse_jwt_payload::<A, SinglePurposeToken>(request_headers, state).await?; | ||
| if payload.check_in_blacklist(state).await? { | ||
| return Err(errors::ApiErrorResponse::InvalidJwtToken.into()); | ||
| } | ||
|
|
||
| Ok(( | ||
| (), | ||
| AuthenticationType::SinglePurposeJWT { | ||
| user_id: payload.user_id, | ||
| purpose: payload.purpose, | ||
| }, | ||
| )) | ||
| } | ||
| } | ||
|
|
| @@ -43,8 +43,7 @@ impl SPTFlow { | |||
| Self::AcceptInvitationFromEmail | Self::ResetPassword => Ok(true), | |||
| Self::VerifyEmail => Ok(user.0.is_verified), | |||
| // Final Checks | |||
| // TODO: this should be based on last_password_modified_at as a placeholder using false | |||
There was a problem hiding this comment.
Change the From impl for SPTFlow -> Token Purpose
ThisIsMani
reviewed
May 7, 2024
| is_verified: is_verified.unwrap_or(user.is_verified), | ||
| preferred_merchant_id: preferred_merchant_id | ||
| .clone() | ||
| .or(user.preferred_merchant_id.clone()), | ||
| ..user.to_owned() | ||
| }, | ||
| storage::UserUpdate::PasswordUpdate { password } => storage::User { | ||
| password: password.clone().unwrap_or(user.password.clone()), |
There was a problem hiding this comment.
Add last_password_changed_at here.
ThisIsMani
previously approved these changes
May 7, 2024
racnan
previously approved these changes
May 7, 2024
racnan
approved these changes
May 7, 2024
ThisIsMani
approved these changes
May 7, 2024
pixincreate
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Additional Changes
Motivation and Context
Closes #4411
How did you test it?
Use the curl:
Response will 200 Ok for all successful password change.
If current password and new password is same then response will be Invalid password error.
Checklist
cargo +nightly fmt --allcargo clippy