Skip to content

Conversation

deepanshu-iiitu
Copy link
Contributor

@deepanshu-iiitu deepanshu-iiitu commented Apr 30, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR contains the following change:

  • Create data_models is renamed to hyperswitch_domain_models

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

#4514
#4515

How did you test it?

Only crate renamed hence no testing required.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@deepanshu-iiitu deepanshu-iiitu self-assigned this Apr 30, 2024
@deepanshu-iiitu deepanshu-iiitu requested review from a team as code owners April 30, 2024 08:58
@deepanshu-iiitu deepanshu-iiitu added A-core Area: Core flows C-feature Category: Feature request or enhancement labels May 2, 2024
@deepanshu-iiitu deepanshu-iiitu linked an issue May 2, 2024 that may be closed by this pull request
2 tasks
Narayanbhat166
Narayanbhat166 previously approved these changes May 2, 2024
SamraatBansal
SamraatBansal previously approved these changes May 2, 2024
ThisIsMani
ThisIsMani previously approved these changes May 2, 2024
@deepanshu-iiitu deepanshu-iiitu removed the request for review from racnan May 2, 2024 08:42
vspecky
vspecky previously approved these changes May 2, 2024
Copy link
Contributor

@vspecky vspecky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on behalf of @juspay/hyperswitch-routing

SanchithHegde
SanchithHegde previously approved these changes May 2, 2024
lsampras
lsampras previously approved these changes May 2, 2024
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue May 2, 2024
@deepanshu-iiitu deepanshu-iiitu removed this pull request from the merge queue due to a manual request May 2, 2024
@deepanshu-iiitu deepanshu-iiitu dismissed stale reviews from ThisIsMani and SamraatBansal via 8efab32 May 2, 2024 11:10
Copy link
Contributor

@ThisIsMani ThisIsMani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dashboard specific changes looks fine.

@deepanshu-iiitu deepanshu-iiitu requested review from lsampras, Narayanbhat166 and vspecky and removed request for lsampras, Narayanbhat166 and vspecky May 2, 2024 11:44
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit 86e93cd May 2, 2024
@Gnanasundari24 Gnanasundari24 deleted the move-router-data branch May 2, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Rename crate data_models to hyperswitch_domain_models
8 participants