Skip to content

Conversation

ShankarSinghC
Copy link
Contributor

@ShankarSinghC ShankarSinghC commented Apr 29, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This pr adds a api to enable usage of Network Transaction/Reference ID in recurring MIT payments. This will be a business profile level feature that a merchant specifies.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

  1. Create a business profile for a merchant
  2. Use the below curl to enable connector_agnostic_mit feature for the business profile
curl --location 'http://localhost:8080/account/:merchant_id/business_profile/:profile_id/toggle_connector_agnostic_mit' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: api_key' \
--data '{
    "enabled": true
}'
image

image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@ShankarSinghC ShankarSinghC added C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed M-database-changes Metadata: This PR involves database schema changes labels Apr 29, 2024
@ShankarSinghC ShankarSinghC self-assigned this Apr 29, 2024
@ShankarSinghC ShankarSinghC requested review from a team as code owners April 29, 2024 07:19
@ShankarSinghC ShankarSinghC linked an issue Apr 29, 2024 that may be closed by this pull request
vspecky
vspecky previously approved these changes Apr 30, 2024
@Narayanbhat166
Copy link
Contributor

we need not add a separate endpoint for this, have a field in BusinessProfileUpdate

@ShankarSinghC
Copy link
Contributor Author

we need not add a separate endpoint for this, have a field in BusinessProfileUpdate

We need to add api_key auth support for this endpoint, which is not supported by BusinessProfileUpdate

@ShankarSinghC ShankarSinghC requested a review from vspecky May 3, 2024 10:30
@likhinbopanna likhinbopanna added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit e769abe May 7, 2024
@likhinbopanna likhinbopanna deleted the ref/nrid-config branch May 7, 2024 07:35
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: Feature request or enhancement M-database-changes Metadata: This PR involves database schema changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an api to toggle connector_agnostic_mit feature
5 participants