feat(router): add retrieve poll status api #4358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai-harsha-vardhan
added
A-core
…nto add-poll-status-api
crates/router/src/core/poll.rs
Outdated
| .parse_enum("PollStatus") | ||
| .map_err(|err| logger::warn!("error while parsing PollStatus: {err}")) | ||
| .ok() | ||
| .unwrap_or(PollStatus::NotFound) |
There was a problem hiding this comment.
this should be InternalServerError
crates/router/src/core/poll.rs
Outdated
| .ok() | ||
| .unwrap_or(PollStatus::NotFound) | ||
| }) | ||
| .unwrap_or(PollStatus::NotFound); |
There was a problem hiding this comment.
we should return a 4xx in this case because we have poll id in the request path, so if the resource is not found then a 404 should be returned
crates/router/src/core/poll.rs
Outdated
| .attach_printable("Failed to get redis connection")?; | ||
| let request_poll_id = req.poll_id; | ||
| // prepend 'poll_' to restrict access to only fetching Poll IDs, as this is a freely passed string in the request | ||
| let poll_id = format!("poll_{}", request_poll_id); |
There was a problem hiding this comment.
how are we restricting access control for poll ids? A merchant with a publishable key can access poll status of other merchants?
Narayanbhat166
approved these changes
Apr 17, 2024
ivor11
approved these changes
Apr 17, 2024
pixincreate
added a commit
that referenced
this pull request
Apr 18, 2024
…en-capture-status-handle * 'main' of github.com:juspay/hyperswitch: feat(router): add retrieve poll status api (#4358)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
add retrieve poll status api
This is a generic poll status retrieve API, which can be used in any polling flows. application will set a poll_id in backend as pending, and sends back a poll_id to client to keep polling until the status is completed. once it turns to completed, client will do the required action. This is a light weight alternative to actually polling with the payment status or similar heavy apis.
Additional Changes
Motivation and Context
How did you test it?
Tested Manually
Expected 200 response
Checklist
cargo +nightly fmt --allcargo clippy