feat(router): add external authentication webhooks flow #4339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai-harsha-vardhan
added
A-core
crates/router/src/core/webhooks.rs
Outdated
| authentication_id, | ||
| ) | ||
| .await | ||
| .to_not_found_response(errors::ApiErrorResponse::InternalServerError) |
There was a problem hiding this comment.
shouldn't this be a 4xx?
crates/router/src/core/webhooks.rs
Outdated
| connector_authentication_id, | ||
| ) | ||
| .await | ||
| .to_not_found_response(errors::ApiErrorResponse::InternalServerError) |
There was a problem hiding this comment.
This also should be a 4xx
| "received a non-external-authentication id for retrieving authentication", | ||
| ) | ||
| }?; | ||
| let updated_authentication = state |
There was a problem hiding this comment.
should we move this configuration to merchant connector account?
| @@ -40,6 +40,8 @@ pub struct Authentication { | |||
| pub acs_trans_id: Option<String>, | |||
| pub three_ds_server_trans_id: Option<String>, | |||
| pub acs_signed_content: Option<String>, | |||
| pub profile_id: String, | |||
| pub payment_id: Option<String>, | |||
There was a problem hiding this comment.
we should also have merchant_connector_id
crates/router/src/core/webhooks.rs
Outdated
| business_profile, | ||
| )) | ||
| .await | ||
| .attach_printable("Incoming webhook flow for mandates failed")? |
There was a problem hiding this comment.
Suggested change
| .attach_printable("Incoming webhook flow for mandates failed")? | |
| .attach_printable("Incoming webhook flow for external authentication failed")? |
|
|
||
| #[derive(Clone, Debug, Deserialize)] | ||
| pub struct ExternalThreeDSConnectorMetadata { | ||
| pub pull_mechanism_for_external_3ds_enabled: Option<String>, |
There was a problem hiding this comment.
can we have this as an enum or bool instead of string?
Narayanbhat166
approved these changes
Apr 16, 2024
hrithikesh026
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
add external authentication webhooks flow
When external 3ds authentication is completed, the result of the challenge along with cavv, eci values are sent as a notification from 3ds connectors. We should consume the webhook (only if 3ds connector psync is not enabled), and then do the payments confirm to perform the authorization.
Additional Changes
Motivation and Context
How did you test it?
Sanity testing of payments, refunds and dispute webhooks (both using mca_id and connector name in url path)
Authentication webhooks can't be tested (will be implementing for netcetera then we'll be able to test)
Checklist
cargo +nightly fmt --allcargo clippy