Skip to content

Conversation

vspecky
Copy link
Contributor

@vspecky vspecky commented Mar 13, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR fixes the issue where token data fetch from Redis was failing for 3DS payments going through the complete authorize flow. The issue being that the payment method was being taken from the request, where it may not be present. The solution was to add the payment method stored in the payment attempt as a fallback.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Certain connectors confirm their payments through the Complete Authorize flow when it comes to 3DS. To ensure that the token data fetch for this flow doesn't fail, we should be using the payment attempt as the fallback ground of truth for any missing data. This PR adds this fallback.

How did you test it?

3DS Payments with Cybersource (failing before, passing now)
Payment Confirmation:
image

Payment Redirection (Succeeding):
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@vspecky vspecky added A-core Area: Core flows C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 A-payments Area: payments labels Mar 13, 2024
@vspecky vspecky added this to the March 2024 milestone Mar 13, 2024
@vspecky vspecky self-assigned this Mar 13, 2024
@vspecky vspecky requested a review from a team as a code owner March 13, 2024 07:12
@vspecky vspecky linked an issue Mar 13, 2024 that may be closed by this pull request
2 tasks
@bernard-eugine bernard-eugine disabled auto-merge March 13, 2024 07:47
@bernard-eugine bernard-eugine merged commit ada0002 into main Mar 13, 2024
@bernard-eugine bernard-eugine deleted the fix/three-ds-complete-authorize branch March 13, 2024 07:48
@pixincreate pixincreate removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows A-payments Area: payments C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 3DS Payments through Complete Authorize flow failing
5 participants