feat(connector): [Checkout] add support for external authentication for checkout connector #4006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odules-for-external-authn
…odules-for-external-authn
…pis-for-external-authn
sai-harsha-vardhan
added
A-connector-integration
ArjunKarthik
reviewed
Mar 7, 2024
| let three_ds = match item.router_data.auth_type { | ||
| enums::AuthenticationType::ThreeDs => CheckoutThreeDS { | ||
| enabled: true, | ||
| force_3ds: true, | ||
| eci: authentication_data.clone().and_then(|auth| auth.eci), |
There was a problem hiding this comment.
Don't clone authentication_data, instead clone the required fields
sai-harsha-vardhan
changed the base branch from
add-new-payment-apis-for-external-authn
to
main
sai-harsha-vardhan
changed the base branch from
main
to
add-new-payment-apis-for-external-authn
ArjunKarthik
previously approved these changes
Mar 8, 2024
Gnanasundari24
dismissed
ArjunKarthik’s stale review
The base branch was changed.
ArjunKarthik
approved these changes
Mar 9, 2024
ThisIsMani
approved these changes
Mar 9, 2024
prajjwalkumar17
approved these changes
Mar 9, 2024
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
add support for external authentication for checkout connector
Additional Changes
Motivation and Context
How did you test it?
Compiler guided, Sanity payments through checkout including threeDs payments
Checklist
cargo +nightly fmt --allcargo clippy