-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Refactor(core): status handling for payment_method_status #3965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay/hyperswitch into feat/core_pm_id_in_response
…ay/hyperswitch into feat/core_pm_id_in_response
…rigin' into refactor/status_handling_for_pm
…juspay/hyperswitch into refactor/status_handling_for_pm
vspecky
previously approved these changes
Mar 8, 2024
srujanchikke
previously approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No connector files were changed in this PR.
The base branch was changed.
vspecky
approved these changes
Mar 11, 2024
apoorvdixit88
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No dashboard specific changes!
srujanchikke
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Status for Payment Method is mapped according to the response received from connector.
If it is a Successful captured response we will set the PM as active.
else if it is failed it will set as inactive and for other states it will be in processing state.
Additional Changes
Motivation and Context
How did you test it?
Can be tested out by doing a retreive on a 3ds enabled payment.
We will have
payment_method_id
andpayment_method_status
in every payment's response(except Create).Sample curl:
Payment
done using token:Payment's Confirm
Response should include these two fields
(This will be updated after @vspecky PR linking issue here)
Payment
done using Payment Data & Customer Acceptance:Payment's Confirm
Response should include these two fields null as we are doing the operation of saving card in tokio spawn.
Checklist
cargo +nightly fmt --all
cargo clippy