Skip to content

Conversation

lsampras
Copy link
Contributor

@lsampras lsampras commented Nov 2, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Add AuthenticationType enum to represent the various possible authentication types
  • update the AuthenticateAndFetch to also return the type of authentication
  • Add this authentication type field to api event

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

  • This info now allows us to audit our api calls more precisely about the source of these api calls

How did you test it?

  • checking local logs after an API request
Screenshot 2023-11-02 at 2 20 14 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@lsampras lsampras added the C-feature Category: Feature request or enhancement label Nov 2, 2023
@lsampras lsampras self-assigned this Nov 2, 2023
@lsampras lsampras requested review from a team as code owners November 2, 2023 09:07
@lsampras lsampras added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit 1094493 Nov 2, 2023
@lsampras lsampras deleted the add_incoming_source branch November 2, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: Feature request or enhancement
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

5 participants