Skip to content

feat(connector): [ACI] Currency Unit Conversion #2750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 5, 2023
Merged

feat(connector): [ACI] Currency Unit Conversion #2750

merged 5 commits into from
Nov 5, 2023

Conversation

Harshwardhan9431
Copy link
Contributor

@Harshwardhan9431 Harshwardhan9431 commented Oct 31, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Harshwardhan9431 Harshwardhan9431 requested a review from a team as a code owner October 31, 2023 17:15
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Oct 31, 2023
@Harshwardhan9431 Harshwardhan9431 changed the title Feature(Connector): Aci_Currency_Unit_Conversion feat(Connector): Aci_Currency_Unit_Conversion Oct 31, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Oct 31, 2023
@swangi-kumari swangi-kumari self-requested a review October 31, 2023 17:59
@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 31, 2023
@swangi-kumari swangi-kumari linked an issue Oct 31, 2023 that may be closed by this pull request
[FEATURE]: [ACI] Currency Unit Conversion #2198
Closed
2 tasks
@swangi-kumari swangi-kumari changed the title feat(Connector): Aci_Currency_Unit_Conversion feat(Connector): [Aci] Currency Unit Conversion Oct 31, 2023
swangi-kumari
swangi-kumari previously approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@swangi-kumari swangi-kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AkshayaFoiger AkshayaFoiger self-requested a review November 2, 2023 07:13
AkshayaFoiger
AkshayaFoiger requested changes Nov 2, 2023
View reviewed changes
@swangi-kumari
Copy link
Contributor

Hey @Harshwardhan9431 ,
Thanks for your interest in contributing to hyperswitch.
Let us know if you need any assistance from our end.
Also, even if hacktoberfest is over, we should celebrate open source everyday and we are open for more contributions from you.
We would still be rewarding folks with goodies even if the PR gets merged post hacktoberfest.
May the Source be with you!

@AkshayaFoiger AkshayaFoiger added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Nov 2, 2023
@Harshwardhan9431
Copy link
Contributor Author

Yeah Done :)

@Harshwardhan9431 Harshwardhan9431 changed the title feat(Connector): [Aci] Currency Unit Conversion feat(Connector): Aci Currency Unit Conversion Nov 2, 2023
@Harshwardhan9431 Harshwardhan9431 changed the title feat(Connector): Aci Currency Unit Conversion feat(Connector): [Aci] Currency Unit Conversion Nov 2, 2023
@Harshwardhan9431 Harshwardhan9431 changed the title feat(Connector): [Aci] Currency Unit Conversion feat(connector): [Aci] Currency Unit Conversion Nov 2, 2023
@AkshayaFoiger AkshayaFoiger changed the title feat(connector): [Aci] Currency Unit Conversion feat(connector): [ACI] Currency Unit Conversion Nov 2, 2023
@AkshayaFoiger AkshayaFoiger removed the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Nov 2, 2023
@swangi-kumari swangi-kumari changed the title feat(connector): [ACI] Currency Unit Conversion feat(connector): [ACI Worldwide] Currency Unit Conversion Nov 3, 2023
@swangi-kumari swangi-kumari changed the title feat(connector): [ACI Worldwide] Currency Unit Conversion feat(connector): [ACI] Currency Unit Conversion Nov 3, 2023
@AkshayaFoiger
Copy link
Contributor

Looks Good!

@AkshayaFoiger AkshayaFoiger self-requested a review November 3, 2023 07:32
SanchithHegde
SanchithHegde approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @Harshwardhan9431!

@SanchithHegde SanchithHegde added this pull request to the merge queue Nov 5, 2023
@SanchithHegde SanchithHegde added the hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions label Nov 5, 2023
Merged via the queue into juspay:main with commit cdead78 Nov 5, 2023
@deepanshu-iiitu
Copy link
Contributor

Hey @Harshwardhan9431 ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@swangi-kumari swangi-kumari swangi-kumari approved these changes

@AkshayaFoiger AkshayaFoiger AkshayaFoiger approved these changes

@srujanchikke srujanchikke Awaiting requested review from srujanchikke

Assignees

@Harshwardhan9431 Harshwardhan9431

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [ACI] Currency Unit Conversion
5 participants
@Harshwardhan9431 @swangi-kumari @AkshayaFoiger @deepanshu-iiitu @SanchithHegde