Skip to content

feat(connector): [NMI] add orderid to PaymentRequest #2727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2023
Merged

feat(connector): [NMI] add orderid to PaymentRequest #2727

merged 1 commit into from
Oct 31, 2023

Conversation

sahalsaad
Copy link
Contributor

@sahalsaad sahalsaad commented Oct 30, 2023 •
edited by deepanshu-iiitu
Loading

Add orderid with value of connector_request_reference_id in NMI transformers.

Fixes #2306

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Make any Payment for connector NMI and see that you are getting "reference_id" field in the logs of payment request.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@sahalsaad
feat(connector): [NMI] add orderid to PaymentRequest
15ec45f 
Add orderid with value of connector_request_reference_id in NMI transformers.

Fixes juspay#2306
@sahalsaad sahalsaad requested a review from a team as a code owner October 30, 2023 02:40
@prasunna09 prasunna09 added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 30, 2023
@prasunna09 prasunna09 added this to the October 2023 Milestone milestone Oct 30, 2023
srujanchikke
srujanchikke approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@srujanchikke srujanchikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Oct 31, 2023
Merged via the queue into juspay:main with commit aad3f0f Oct 31, 2023
@deepanshu-iiitu
Copy link
Contributor

Hey @sahalsaad ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

@swangi-kumari swangi-kumari added hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 31, 2023
@sahalsaad sahalsaad deleted the feat/update-reference-nmi branch October 31, 2023 16:32
Abhicodes-crypto pushed a commit that referenced this pull request Nov 6, 2023
@sahalsaad @Abhicodes-crypto
feat(connector): [NMI] add orderid to PaymentRequest (#2727)
84523fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujanchikke srujanchikke srujanchikke approved these changes

@AkshayaFoiger AkshayaFoiger AkshayaFoiger approved these changes

@SamraatBansal SamraatBansal Awaiting requested review from SamraatBansal

@Sangamesh26 Sangamesh26 Awaiting requested review from Sangamesh26

Assignees

@sahalsaad sahalsaad

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
October 2023 Milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [NMI] Use connector_request_reference_id as reference to the connector
7 participants
@sahalsaad @deepanshu-iiitu @srujanchikke @AkshayaFoiger @prasunna09 @swangi-kumari @Gnanasundari24