Skip to content

Conversation

prasunna09
Copy link
Contributor

@prasunna09 prasunna09 commented Oct 26, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Remove default case handling for Cryptopay - Payment Status

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Test cases - Make a test payment and test webhooks.
Make an overpaid payment - after redirecting, give more amount, then payment is considered as Overpaid, and then from dashboard, refund it.
Expected behavior - Should get a Unresolved Webhook and then Completed Webhook, and then payment should be succeeded.

Make an Underpaid payment - after redirecting, give less amount, then payment is considered as Underpaid, and then from dashboard, refund it.
Expected behavior - Should get a Unresolved Webhook and then Refunded Webhook, and then payment should be in unresolved.

Make an PaidLate payment - Collect all the transaction details and pay late i.e. after the timer ended, then payment is considered as Paidlate, and then from dashboard, refund it.
Expected behavior - Should get a Unresolved Webhook and then Refunded Webhook, and then payment should be in unresolved.

Screenshot 2023-10-25 at 4 36 12 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@prasunna09 prasunna09 added A-connector-integration Area: Connector integration C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 26, 2023
@prasunna09 prasunna09 added this to the October 2023 Milestone milestone Oct 26, 2023
@prasunna09 prasunna09 self-assigned this Oct 26, 2023
@prasunna09 prasunna09 requested a review from a team as a code owner October 26, 2023 12:41
@ArjunKarthik
Copy link
Contributor

@prasunna09 Please get clarity on when we can get refunded status from the connector and do the mapping accordingly

@ArjunKarthik ArjunKarthik added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Oct 27, 2023
@likhinbopanna likhinbopanna added this pull request to the merge queue Nov 3, 2023
Merged via the queue into main with commit 255a4f8 Nov 3, 2023
@likhinbopanna likhinbopanna deleted the remove-default-case-for-cryptopay-status branch November 3, 2023 12:23
@juspay juspay deleted a comment from hankqqu Nov 5, 2023
@SanchithHegde SanchithHegde removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

5 participants