Skip to content

refactor(connector): Use connector_request_reference_id for Fiserv #2698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 27, 2023
Merged

refactor(connector): Use connector_request_reference_id for Fiserv #2698

merged 4 commits into from
Oct 27, 2023

Conversation

TejasMate
Copy link
Contributor

@TejasMate TejasMate commented Oct 26, 2023 •
edited by swangi-kumari
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Make any Payment for connector Fiserv and see that you are getting "reference_id" field in the logs of payment request.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@TejasMate TejasMate requested a review from a team as a code owner October 26, 2023 11:51
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Oct 26, 2023
@TejasMate TejasMate changed the title [FEATURE]: [Fiserv] Use connector_request_reference_id as reference t… refactor(connector): Use connector_request_reference_id for Fiserv Oct 26, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Oct 26, 2023
@TejasMate TejasMate mentioned this pull request Oct 26, 2023
Closed
2 tasks
@deepanshu-iiitu deepanshu-iiitu linked an issue Oct 26, 2023 that may be closed by this pull request
[FEATURE]: [Fiserv] Use connector_request_reference_id as reference to the connector #2298
Closed
2 tasks
@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 26, 2023
@swangi-kumari
Copy link
Contributor

Hey @TejasMate ,
Pls address the CI fails
Run cargo +nightly fmt for formatting.

@TejasMate TejasMate closed this Oct 26, 2023
@TejasMate TejasMate deleted the TejasMate-patch-1 branch October 26, 2023 17:22
@TejasMate TejasMate restored the TejasMate-patch-1 branch October 26, 2023 17:26
@TejasMate TejasMate reopened this Oct 26, 2023
SamraatBansal
SamraatBansal approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@SamraatBansal SamraatBansal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ref: https://developer.fiserv.com/product/CommerceHub/docs/?path=docs/Resources/Master-Data/Transaction-Details.md&branch=main

@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Oct 27, 2023
Merged via the queue into juspay:main with commit 05c2f84 Oct 27, 2023
@swangi-kumari
Copy link
Contributor

Hey @TejasMate ,
Thanks a bunch for all your contributions! We’ve got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

@swangi-kumari swangi-kumari added the hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions label Oct 27, 2023
@TejasMate TejasMate deleted the TejasMate-patch-1 branch October 29, 2023 14:25
Abhicodes-crypto pushed a commit that referenced this pull request Nov 6, 2023
@Abhicodes-crypto
refactor(connector): Use connector_request_reference_id for Fiserv (#…
48b2284 
…2698)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamraatBansal SamraatBansal SamraatBansal approved these changes

+1 more reviewer

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@TejasMate TejasMate

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [Fiserv] Use connector_request_reference_id as reference to the connector
5 participants
@TejasMate @swangi-kumari @ArjunKarthik @SamraatBansal @Gnanasundari24