Skip to content

refactor(connector): default case for worldline #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 25, 2023
Merged

refactor(connector): default case for worldline #2674

merged 9 commits into from
Oct 25, 2023

Conversation

Hangsaai
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

#2289

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Hangsaai Hangsaai requested a review from a team as a code owner October 24, 2023 09:39
@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 25, 2023
SanchithHegde
SanchithHegde approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @Hangsaai!

@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 25, 2023
@SanchithHegde SanchithHegde added the hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions label Oct 25, 2023
Merged via the queue into juspay:main with commit e6272c6 Oct 25, 2023
@swangi-kumari
Copy link
Contributor

Hey @Hangsaai ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

@swangi-kumari swangi-kumari linked an issue Oct 25, 2023 that may be closed by this pull request
[REFACTOR]: [Worldline] Remove Default Case Handling #2289
Closed
2 tasks
@swangi-kumari swangi-kumari mentioned this pull request Oct 25, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@SamraatBansal SamraatBansal SamraatBansal approved these changes

@ArjunKarthik ArjunKarthik Awaiting requested review from ArjunKarthik

+1 more reviewer

@Sangamesh26 Sangamesh26 Sangamesh26 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Hangsaai Hangsaai

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR]: [Worldline] Remove Default Case Handling
5 participants
@Hangsaai @swangi-kumari @SanchithHegde @SamraatBansal @Sangamesh26