Skip to content

feat(connector): [Mollie] Currency Unit Conversion #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 27, 2023
Merged

feat(connector): [Mollie] Currency Unit Conversion #2671

merged 10 commits into from
Oct 27, 2023

Conversation

SagarDevAchar
Copy link
Contributor

@SagarDevAchar SagarDevAchar commented Oct 23, 2023 •
edited by deepanshu-iiitu
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Addressing Issue: [FEATURE]: [Mollie] Currency Unit Conversion #2231
  • Modified two files in hyperswitch/crates/router/src/connector/
    • mollie.rs
      • Implement get_currency_unit function
      • Modify ConnectorIntegration implementations for Mollie
    • mollie/transformers.rs
      • Implement MollieRouterData<T> structure and functionality
      • Modify implementation for MolliePaymentsRequest

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

We need to create a payment using mollie and test the currency unit from connector response and connector dashboard.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SagarDevAchar SagarDevAchar requested a review from a team as a code owner October 23, 2023 14:15
@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 25, 2023
SamraatBansal
SamraatBansal requested changes Oct 25, 2023
View reviewed changes
@swangi-kumari swangi-kumari added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Oct 25, 2023
@preetamrevankar preetamrevankar added this pull request to the merge queue Oct 27, 2023
Merged via the queue into juspay:main with commit 3578db7 Oct 27, 2023
@swangi-kumari swangi-kumari added hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Oct 27, 2023
@swangi-kumari swangi-kumari mentioned this pull request Oct 27, 2023
Closed
2 tasks
@swangi-kumari
Copy link
Contributor

Hey @SagarDevAchar ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

@SagarDevAchar SagarDevAchar deleted the mollie_issue_2231 branch October 28, 2023 02:10
@zakhaev26 zakhaev26 mentioned this pull request Oct 31, 2023
Closed
2 tasks
Abhicodes-crypto pushed a commit that referenced this pull request Nov 6, 2023
@SagarDevAchar @SamraatBansal @Abhicodes-crypto
feat(connector): [Mollie] Currency Unit Conversion (#2671)
c03821a 
Co-authored-by: SamraatBansal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamraatBansal SamraatBansal SamraatBansal approved these changes

+1 more reviewer

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@SagarDevAchar SagarDevAchar

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SagarDevAchar @swangi-kumari @ArjunKarthik @SamraatBansal @preetamrevankar