Skip to content

refactor(connector): [Dlocal] remove default case handling #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 19, 2023
Merged

refactor(connector): [Dlocal] remove default case handling #2624

merged 4 commits into from
Oct 19, 2023

Conversation

saikiranpatil
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

removed all the default case in dlocal and handle all the missing cases
closes #2269

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@saikiranpatil saikiranpatil requested a review from a team as a code owner October 18, 2023 08:01
@SanchithHegde
Copy link
Member

Hey @saikiranpatil, could you address the failing CI checks?

@SanchithHegde SanchithHegde added A-connector-integration Area: Connector integration S-waiting-on-author Status: This PR is incomplete or needs to address review comments C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 18, 2023
@saikiranpatil
Copy link
Contributor Author

i will check

@saikiranpatil
Copy link
Contributor Author

@SanchithHegde, CI failing is resolved, can you check this PR

SanchithHegde
SanchithHegde approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @saikiranpatil!

@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 19, 2023
@SanchithHegde SanchithHegde added hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Oct 19, 2023
@SanchithHegde SanchithHegde removed this pull request from the merge queue due to a manual request Oct 19, 2023
@SanchithHegde SanchithHegde changed the title refactor(connector): remove default case handling refactor(connector): [Dlocal] remove default case handling Oct 19, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 19, 2023
Merged via the queue into juspay:main with commit 1584313 Oct 19, 2023
@swangi-kumari
Copy link
Contributor

Hey @saikiranpatil ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

+1 more reviewer

@Sangamesh26 Sangamesh26 Sangamesh26 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@saikiranpatil saikiranpatil

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR]: [Dlocal] Remove Default Case Handling
4 participants
@saikiranpatil @SanchithHegde @swangi-kumari @Sangamesh26