refactor(payment_connector): allow connector label to be updated #2622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narayanbhat166
added
the
S-waiting-on-review
Narayanbhat166
changed the title
ThisIsMani
previously approved these changes
Oct 18, 2023
postman/collection-dir/stripe/PaymentConnectors/Payment Connector - Update/event.test.js
Outdated
Show resolved
Hide resolved
Gnanasundari24
approved these changes
Oct 18, 2023
SanchithHegde
approved these changes
Oct 18, 2023
SanchithHegde
added
A-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This change will allow the
connector_labelto be passed in the create and update request, in create if it is not passed then the default connector label will be created in the form ofconnector_name_profile_name.Additional Changes
Motivation and Context
Allow custom labels to be passed for a connector.
How did you test it?
Create a connector with custom connector label.
Update the connector with another connector label.
Postman tests
Checklist
cargo +nightly fmt --allcargo clippy