Skip to content

refactor: refactor connector auth type failure to 4xx #2616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2023
Merged

refactor: refactor connector auth type failure to 4xx #2616

merged 2 commits into from
Oct 18, 2023

Conversation

ArjunKarthik
Copy link
Contributor

@ArjunKarthik ArjunKarthik commented Oct 17, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Serialization error due to wrong configuration of connector auth type should be 400 instead of 5xx during payments

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

https://github.com/juspay/hyperswitch-cloud/issues/2674

How did you test it?

Manual Testing - Postman

  1. Test payment with wrongly configured connector_account_details for any connector, 4xx error will thrown in the response. Right now we have auth type validation for every connector, this can be tested for the MCA which was configured wrongly before the validation changes.
Screenshot 2023-10-17 at 7 13 24 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ArjunKarthik ArjunKarthik requested review from a team as code owners October 17, 2023 13:52
@ArjunKarthik ArjunKarthik self-assigned this Oct 17, 2023
@ArjunKarthik ArjunKarthik added A-connector-integration Area: Connector integration C-refactor Category: Refactor S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 17, 2023
@ArjunKarthik ArjunKarthik added this to the October 2023 Milestone milestone Oct 17, 2023
@ArjunKarthik ArjunKarthik force-pushed the ConnectorAuthFailures branch 2 times, most recently from 0f9bc80 to 54652fd Compare October 17, 2023 17:49
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Oct 18, 2023
@ArjunKarthik ArjunKarthik removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 18, 2023
Merged via the queue into main with commit 1dad745 Oct 18, 2023
@Gnanasundari24 Gnanasundari24 deleted the ConnectorAuthFailures branch October 18, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@SamraatBansal SamraatBansal SamraatBansal approved these changes

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

Assignees

@ArjunKarthik ArjunKarthik

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor
Projects
None yet
Milestone
October 2023 Milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ArjunKarthik @jarnura @SamraatBansal @sai-harsha-vardhan @Gnanasundari24