Skip to content

feat(connector): [Klarna] Add order id as the reference id to merchant #2614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 19, 2023
Merged

feat(connector): [Klarna] Add order id as the reference id to merchant #2614

merged 5 commits into from
Oct 19, 2023

Conversation

jay-tau
Copy link
Contributor

@jay-tau jay-tau commented Oct 17, 2023 •
edited by SanchithHegde
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Resolves #2334

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@jay-tau jay-tau requested a review from a team as a code owner October 17, 2023 13:15
@SanchithHegde
Copy link
Member

@jay-tau Can you address the failing CI checks?

@SanchithHegde SanchithHegde added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-waiting-on-author Status: This PR is incomplete or needs to address review comments hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 17, 2023
@jay-tau
Copy link
Contributor Author

jay-tau commented Oct 18, 2023 via email

@jay-tau
Copy link
Contributor Author

jay-tau commented Oct 18, 2023 •
edited
Loading

@SanchithHegde I have addressed the failing CI checks.
Could you please approve the remaining workflows

@SanchithHegde SanchithHegde changed the title feat(connector): [Klarna] Add order id as the reference id (#2334) feat(connector): [Klarna] Add order id as the reference id Oct 19, 2023
@SanchithHegde SanchithHegde changed the title feat(connector): [Klarna] Add order id as the reference id feat(connector): [Klarna] Add order id as the reference id to merchant Oct 19, 2023
SanchithHegde
SanchithHegde approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @jay-tau!

@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 19, 2023
@SanchithHegde SanchithHegde added hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Oct 19, 2023
Merged via the queue into juspay:main with commit b7d5573 Oct 19, 2023
@swangi-kumari
Copy link
Contributor

Hey @jay-tau ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

+1 more reviewer

@Sangamesh26 Sangamesh26 Sangamesh26 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jay-tau jay-tau

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [Klarna] Use connector_response_reference_id as reference to merchant
4 participants
@jay-tau @SanchithHegde @swangi-kumari @Sangamesh26