-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix(connector): [Paypal]fix error deserelization for source verification call #2611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArjunKarthik
suggested changes
Oct 17, 2023
Comment on lines
192
to
198
let reason = match error_reason { | ||
Some(err_reason) => err_reason | ||
.is_empty() | ||
.then(|| response.message.to_owned()) | ||
.or(Some(err_reason)), | ||
None => Some(response.message.to_owned()), | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
let reason = match error_reason { | |
Some(err_reason) => err_reason | |
.is_empty() | |
.then(|| response.message.to_owned()) | |
.or(Some(err_reason)), | |
None => Some(response.message.to_owned()), | |
}; | |
let reason = error_reason | |
.unwrap_or(response.message.to_owned()) | |
.is_empty() | |
.then_some(response.message.to_owned()); |
ArjunKarthik
approved these changes
Oct 17, 2023
prasunna09
approved these changes
Oct 18, 2023
Gnanasundari24
approved these changes
Oct 18, 2023
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
fix error deserelization for source verification call . Make description in error response as optional field as it is not expected incase of webhook source verification call
Additional Changes
Motivation and Context
fix error deserelization for source verification call . Make description in error response as optional field as it is not expected incase of webhook source verification call
How did you test it?
1)error deserilization success scenario ,

Source verifcation is failure as secret is not set in merchant connector account ,By default we provide secret as
default_string
. when we include_
in webhook secret paypal throws error as follow"name": "INVALID_REQUEST", "message": "Request is not well-formed, syntactically incorrect, or violates schema.", "debug_id": "c2a4be266f6d6", "details": [ { "field": "/webhook_id", "value": "sruj*an", "location": "body", "issue": "must match \"^[a-zA-Z0-9]+$\"" } ],
Checklist
cargo +nightly fmt --all
cargo clippy