Skip to content

Conversation

prajjwalkumar17
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Earlier we were throwing 2xx even when applepay verification was failing refactored it to throw 4xx

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@prajjwalkumar17 prajjwalkumar17 added A-core Area: Core flows P-high Priority: High S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor A-errors Area: error messages, structure & logging R-waiting-on-L1 A-payments Area: payments labels Oct 17, 2023
@prajjwalkumar17 prajjwalkumar17 requested a review from a team as a code owner October 17, 2023 08:11
@prajjwalkumar17 prajjwalkumar17 self-assigned this Oct 17, 2023
@likhinbopanna
Copy link
Contributor

@prajjwalkumar17 Can you add the required test cases?

@prajjwalkumar17
Copy link
Member Author

Previously we were getting 2xx even when this was error response

Screenshot 2023-10-17 at 15 14 20

After this PR going in we will have the 4xx instead of 2xx
The CURL is

curl --location 'https://sandbox.hyperswitch.io/verify/apple_pay/merchant_1696932076' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: snd_XQpKjqRt9Z142lWu8KAF78MYyptaHEJhKdCmo01XEIgdyWfpSA7ByuM4FZnJccj5' \
--data '{
    "domain_names":["hyperswitch-demo-store.netlify."],
    "merchant_connector_account_id": "mca_UcnrI7xaIbHMAKZ7mABw"
}'

@likhinbopanna likhinbopanna added this pull request to the merge queue Oct 17, 2023
Merged via the queue into main with commit cecea87 Oct 17, 2023
@likhinbopanna likhinbopanna deleted the refactor/applepay_response branch October 17, 2023 09:55
@SanchithHegde SanchithHegde removed P-high Priority: High S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows A-errors Area: error messages, structure & logging A-payments Area: payments C-refactor Category: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants