Skip to content

feat(connector): [Iatapay] currency unit conversion #2592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 31, 2023
Merged

feat(connector): [Iatapay] currency unit conversion #2592

merged 10 commits into from
Oct 31, 2023

Conversation

SoumyoPurkayastha
Copy link
Contributor

@SoumyoPurkayastha SoumyoPurkayastha commented Oct 15, 2023 •
edited by deepanshu-iiitu
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

We need to create a payment using Iatapay and test the currency unit from connector response and connector dashboard.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SoumyoPurkayastha SoumyoPurkayastha requested a review from a team as a code owner October 15, 2023 07:21
@SoumyoPurkayastha SoumyoPurkayastha changed the title refactor(connector): [Iatapay] currency unit conversion feat(connector): [Iatapay] currency unit conversion Oct 15, 2023
@prasunna09 prasunna09 added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 15, 2023
@prasunna09 prasunna09 added this to the October 2023 Milestone milestone Oct 15, 2023
@swangi-kumari swangi-kumari linked an issue Oct 17, 2023 that may be closed by this pull request
[FEATURE]: [IataPay] Currency Unit Conversion #2229
Closed
2 tasks
@SoumyoPurkayastha
Copy link
Contributor Author

@SanchithHegde @prasunna09 Could you please review this PR and suggest changes if needed

@swangi-kumari
Copy link
Contributor

Hey @SoumyoPurkayastha , Thanks for PR!
Can you please resolve the conflicts?

@SoumyoPurkayastha SoumyoPurkayastha marked this pull request as draft October 24, 2023 09:58
@SoumyoPurkayastha
Copy link
Contributor Author

SoumyoPurkayastha commented Oct 24, 2023 •
edited
Loading

@swangi-kumari Thanks for pointing the issue out. I'll fix it and then reopen the PR

@SoumyoPurkayastha SoumyoPurkayastha marked this pull request as ready for review October 24, 2023 11:58
SamraatBansal
SamraatBansal requested changes Oct 25, 2023
View reviewed changes
SamraatBansal
SamraatBansal requested changes Oct 25, 2023
View reviewed changes
@deepanshu-iiitu
Copy link
Contributor

Hi @SoumyoPurkayastha
Please address the PR comments as tomorrow is the last day of Hacktoberfest.

@SoumyoPurkayastha
Copy link
Contributor Author

@SamraatBansal I've made the requested changes, please review them

srujanchikke
srujanchikke approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@srujanchikke srujanchikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR @SoumyoPurkayastha

@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Oct 31, 2023
Merged via the queue into juspay:main with commit 0f5406c Oct 31, 2023
@deepanshu-iiitu
Copy link
Contributor

Hey @SoumyoPurkayastha ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

@SanchithHegde SanchithHegde added hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 5, 2023
Abhicodes-crypto pushed a commit that referenced this pull request Nov 6, 2023
@SoumyoPurkayastha @SamraatBansal @Abhicodes-crypto
feat(connector): [Iatapay] currency unit conversion (#2592)
c739456 
Co-authored-by: SamraatBansal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamraatBansal SamraatBansal SamraatBansal approved these changes

@srujanchikke srujanchikke srujanchikke approved these changes

@ArjunKarthik ArjunKarthik Awaiting requested review from ArjunKarthik

@prasunna09 prasunna09 Awaiting requested review from prasunna09

Assignees

@SoumyoPurkayastha SoumyoPurkayastha

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
October 2023 Milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [IataPay] Currency Unit Conversion
8 participants
@SoumyoPurkayastha @swangi-kumari @deepanshu-iiitu @SamraatBansal @srujanchikke @SanchithHegde @prasunna09 @Gnanasundari24