Skip to content

feat(router): Add Cancel Event in Webhooks and Mapping it in Stripe #2573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 13, 2023
Merged

feat(router): Add Cancel Event in Webhooks and Mapping it in Stripe #2573

merged 3 commits into from
Oct 13, 2023

Conversation

deepanshu-iiitu
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Add new IncomingWebhookEvent which will handle the payment cancel webhooks.
Map the above event in Stripe.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Processing of cancel webhooks from connector will be supported for stripe.

How did you test it?

Testing was carried out using Webhooks
Screenshot 2023-10-13 at 3 54 21 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@deepanshu-iiitu deepanshu-iiitu requested review from a team as code owners October 13, 2023 10:24
@deepanshu-iiitu deepanshu-iiitu self-assigned this Oct 13, 2023
@deepanshu-iiitu deepanshu-iiitu added C-feature Category: Feature request or enhancement A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 13, 2023
@sai-harsha-vardhan sai-harsha-vardhan added A-connector-integration Area: Connector integration M-database-changes Metadata: This PR involves database schema changes labels Oct 13, 2023
sai-harsha-vardhan
sai-harsha-vardhan reviewed Oct 13, 2023
View reviewed changes
@ArjunKarthik ArjunKarthik added A-webhooks Area: Webhook flows and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 13, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Oct 13, 2023
Merged via the queue into main with commit 92f7918 Oct 13, 2023
@ArjunKarthik ArjunKarthik deleted the implement-cancel-webhook branch October 13, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

+1 more reviewer

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@deepanshu-iiitu deepanshu-iiitu

Labels
A-connector-integration Area: Connector integration A-core Area: Core flows A-webhooks Area: Webhook flows C-feature Category: Feature request or enhancement M-database-changes Metadata: This PR involves database schema changes
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deepanshu-iiitu @ArjunKarthik @SanchithHegde @sai-harsha-vardhan