Skip to content

feat(connector): [Airwallex] Currency Unit Conversion #2571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 15, 2023
Merged

feat(connector): [Airwallex] Currency Unit Conversion #2571

merged 12 commits into from
Oct 15, 2023

Conversation

SagarDevAchar
Copy link
Contributor

@SagarDevAchar SagarDevAchar commented Oct 13, 2023 •
edited by SanchithHegde
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Addressing Issue: [FEATURE]: [Airwallex] Currency Unit Conversion #2215
  • Modified two files in hyperswitch/crates/router/src/connector/
    • airwallex.rs
      • Implement get_currency_unit function
      • Modify ConnectorIntegration implementations for Airwallex
    • airwallex/transformers.rs
      • Implement AirwallexRouterData<T> structure and functionality
      • Modify implementation for AirwallexPaymentsRequest

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Closes #2215.

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SagarDevAchar SagarDevAchar requested a review from a team as a code owner October 13, 2023 07:44
@SagarDevAchar SagarDevAchar reopened this Oct 13, 2023
@prasunna09 prasunna09 added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 14, 2023
@prasunna09 prasunna09 added this to the October 2023 Milestone milestone Oct 14, 2023
srujanchikke
srujanchikke reviewed Oct 14, 2023
View reviewed changes
srujanchikke
srujanchikke approved these changes Oct 15, 2023
View reviewed changes
Copy link
Contributor

@srujanchikke srujanchikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@srujanchikke srujanchikke added S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 15, 2023
SanchithHegde
SanchithHegde approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @SagarDevAchar!

@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 15, 2023
@SanchithHegde SanchithHegde added hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions and removed S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners labels Oct 15, 2023
Merged via the queue into juspay:main with commit 8971b17 Oct 15, 2023
@SagarDevAchar SagarDevAchar deleted the airwallex_issue_2215 branch October 15, 2023 10:00
@swangi-kumari
Copy link
Contributor

Hey @SagarDevAchar ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@srujanchikke srujanchikke srujanchikke approved these changes

Assignees

@SagarDevAchar SagarDevAchar

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
October 2023 Milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [Airwallex] Currency Unit Conversion
5 participants
@SagarDevAchar @swangi-kumari @SanchithHegde @srujanchikke @prasunna09